Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci update #68

Merged
merged 26 commits into from
Apr 21, 2023
Merged

Ci update #68

merged 26 commits into from
Apr 21, 2023

Conversation

billdenney
Copy link
Contributor

Update CI to the latest versions (on top of #66)

@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Base: 6.45% // Head: 6.45% // No change to project coverage 👍

Coverage data is based on head (afffa0c) compared to base (d970c98).
Patch has no changes to coverable lines.

❗ Current head afffa0c differs from pull request most recent head 963f73b. Consider uploading reports for the commit 963f73b to get more accurate results

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #68   +/-   ##
=====================================
  Coverage   6.45%   6.45%           
=====================================
  Files          2       2           
  Lines         62      62           
=====================================
  Hits           4       4           
  Misses        58      58           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@billdenney
Copy link
Contributor Author

@mattfidler, My best guess is that the issues go back to issues with the nlmixr2extra examples.

@billdenney
Copy link
Contributor Author

@mattfidler, I think that the R-CMD-check issues may be related to memory issues. Only 7 GB of RAM are available: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources.

Any ideas how to slim down the memory use of CI?

@mattfidler
Copy link
Member

Reduce the number of subjects for the estimates. But, that also makes it less useful as a metric for when nlmixr2 has something wrong with it...

@mattfidler
Copy link
Member

You could also use the github ggPMX instead of commenting out the above.

@billdenney
Copy link
Contributor Author

@mattfidler, If this completes with error 143 on the Linux and Mac R-CMD-check tests, then I think that it will be good to merge. It's better than what is currently in place.

The error 143 is related to running some example which is different than a general CI update. Those examples need to be identified and fixed, but that's a separate issue. This will get the pkgdown site building again which has not succeeded in a while.

@mattfidler mattfidler merged commit 8302ce3 into main Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants