Add linting to CI #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds linting to the CI. It also makes linting and testing og the code run in parallel The build job will wait and only run if both the linting and testing succeeds. Currently we use the default linters enabled by the golangci-lint tool: * deadcode * errcheck * gosimple * govet * ineffassign * staticcheck * structcheck * typecheck * unused * varcheck The tool should run all of the previously mentioned in parallel too, so the overhead of this should be relatively minor
|
TODO: Add optional githooks |
|
PR stays as a draft until linting is happy. Keep in mind golangci-lint support turning of linting of untouched files, but personally I think it's better to nip linting problems asap |
There were some linter complaints cause by introducing new linting to the project. Old undetected issues are now resolved.
Avokadoen
force-pushed
the
linting
branch
2 times, most recently
from
7a92d16
to
4fa66c6
Compare
maeb
reviewed
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds linting to the CI. It also makes linting and testing of the code run in parallel
The build job will wait and only run if both the linting and testing succeeds.
Currently we use the default linters enabled by the golangci-lint tool:
The tool should run all of the previously mentioned in parallel too, so the overhead of this should be relatively minor