Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.10.1 zip json.hpp has version number 3.10.0 instead of 3.10.1 #2973

Closed
Andreas-Schniertshauer opened this issue Aug 25, 2021 · 11 comments · Fixed by nlohmann/json_release_scripts#1
Closed

3.10.1 zip json.hpp has version number 3.10.0 instead of 3.10.1 #2973

Andreas-Schniertshauer opened this issue Aug 25, 2021 · 11 comments · Fixed by nlohmann/json_release_scripts#1
Assignees
@nlohmann
Labels
confirmed kind: bug release item: 🔨 further change solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Milestone
Release 3.10.2

Comments

@Andreas-Schniertshauer
Copy link

The version number in json.hpp of zip file 3.10.1 is 3.10.0 instead of 3.10.1,
see comment line 4 and line 35 #define NLOHMANN_JSON_VERSION_PATCH.
Maybe you want also adjust the comment in line 9 Copyright (c) 2013-2019 to 2021.
@nlohmann
Copy link
Owner

Thanks for reporting! The whole tag seems wrong. Yesterday was the first release with a new release script, and apparently something went wrong. :-/

@Andreas-Schniertshauer
Copy link
Author

The good news is that 3.10.1 (zip) compiled with Visual Studio 2019 16.11.1 and all tests (Debug/Release) succeeded.

@dvzrv
Copy link

dvzrv commented Aug 25, 2021

As the tag is not on the correct commit, this also means that the PGP public key 797167AE41C0A6D9232E48457F3CEA63AE251B69 can not be used to verify it.

For packaging purposes on Arch Linux I will use 1fd2213 instead, as it is (AFAICT) the one that should have carried the tag.

archlinux-github pushed a commit to archlinux/svntogit-community that referenced this issue Aug 25, 2021
@dvzrv
upgpkg: nlohmann-json 3.10.1-1: Upgrade to 3.10.1.
615866b 
Use a later commit for the build, as upstream tagged the wrong commit:
nlohmann/json#2973

git-svn-id: file:///srv/repos/svn-community/svn@1004704 9fca08f4-af9d-4005-b8df-a31f2cc04f65
archlinux-github pushed a commit to archlinux/svntogit-community that referenced this issue Aug 25, 2021
@dvzrv
upgpkg: nlohmann-json 3.10.1-1: Upgrade to 3.10.1.
eb9fd64 
Use a later commit for the build, as upstream tagged the wrong commit:
nlohmann/json#2973

git-svn-id: file:///srv/repos/svn-community/svn@1004704 9fca08f4-af9d-4005-b8df-a31f2cc04f65
@xvitaly
Copy link
Contributor

xvitaly commented Aug 25, 2021 •
edited
Loading

@nlohmann Please move tag to 1fd2213 commit.

@nlohmann
Copy link
Owner

How can I move tags?

@xvitaly
Copy link
Contributor

xvitaly commented Aug 25, 2021

How can I move tags?

git tag -d v3.10.1
git push --delete origin v3.10.1

Then create a new one as usually.

@dvzrv
Copy link

dvzrv commented Aug 25, 2021

I would not advise to remove a tag and tag another commit. It will break any downstreams that already rely on e.g. the generated source tarball (it's contents and checksum will change if you do this).

The cleaner solution is always to just create a new release (e.g. v3.10.2).

@xvitaly
Copy link
Contributor

xvitaly commented Aug 25, 2021

The cleaner solution is always to just create a new release (e.g. v3.10.2).

Agree.

@nlohmann
Copy link
Owner

I will prepare a new release soon. I have to check with the release script to check why the tags were not correctly set.

@nlohmann nlohmann self-assigned this Aug 25, 2021
@nlohmann
Copy link
Owner

So this is what happened:

I am using git flow to manage release branches. I created the release branch with

git flow release start 3.10.1

did all the changes and concluded with

git flow release finish 3.10.1

This created the tag 3.10.1, but not v3.10.1, because by default, the config entry versiontag is set to the empty string.

Then I had the release draft for tag v3.10.1 and a pushed tag for 3.10.1. I was confused, removed the 3.10.1 tag and published the release, which created the v3.10.1 tag. Apparently at that point, the changes to master and develop were not yet pushed.

The attached files in the release were correct, because I uploaded them from the working directory of my release script.

This is what I'm going to change:

  • After creating the working copy for the release branch, I execute the command

    git config gitflow.prefix.versiontag v

    to make sure the prefix is correctly set when the release tag is created.

  • I added the missing

    git push --tags

    call to make sure the tag is pushed to GitHub.

@nlohmann nlohmann added solution: proposed fix a fix for the issue has been proposed and waits for confirmation release item: 🔨 further change labels Aug 25, 2021
@nlohmann nlohmann added this to the Release 3.10.2 milestone Aug 25, 2021
nlohmann added a commit to nlohmann/json_release_scripts that referenced this issue Aug 25, 2021
@nlohmann
🐛 fix nlohmann/json#2973
1362917
@nlohmann nlohmann mentioned this issue Aug 25, 2021
Merged
@nlohmann
Copy link
Owner

@Andreas-Schniertshauer @dvzrv @xvitaly

Unless you find a flaw in my explanation and proposal in #2973 (comment), I would wait until the CI for #2976 completes and create the 3.10.2 release tomorrow - reserving the right to immediately delete it if the tag is not set correctly.

kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue Sep 6, 2021
@wangmingyu84 @kraj
nlohmann-json: upgrade 3.9.1 -> 3.10.2
5bfa82d 
Release date: 2021-08-26
SHA-256: 059743e48b37e41579ee3a92e82e984bfa0d2a9a2b20b175d04db8089f46f047 (json.hpp)
61e605be15e88deeac4582aaf01c09d616f8302edde7adcaba9261ddc3b4ceca (include.zip)

Summary
This release is made days after the 3.10.1 release due to a bug in the release script:
The 3.10.1 release at GitHub contained the correct files,
but the associated tag v3.10.1 points to the wrong commit.
This release is made with a fixed build script. All changes are backward-compatible.

Improvements
Fix the release scripts to correctly tag releases. nlohmann/json#2973
Fix some -Wunused warnings on JSON_DIAGNOSTICS when the library is built without CMake.
nlohmann/json#2975
nlohmann/json#2976

Deprecated functions
Passing iterator pairs or pointer/length pairs to parsing functions
(basic_json::parse, basic_json::accept, basic_json::sax_parse, basic_json::from_cbor,
basic_json::from_msgpack, basic_json::from_ubjson, basic_json::from_bson)
via initializer lists is deprecated.
Instead, pass two iterators; for instance, call basic_json::from_cbor(ptr, ptr+len)
instead of basic_json::from_cbor({ptr, len}).

-License-Update: Copyright year updated to 2021.

Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
daregit pushed a commit to daregit/yocto-combined that referenced this issue May 22, 2024
@wangmingyu84 @kraj
src/meta-openembedded:nlohmann-json: upgrade 3.9.1 -> 3.10.2
5f6865d 
Release date: 2021-08-26
SHA-256: 059743e48b37e41579ee3a92e82e984bfa0d2a9a2b20b175d04db8089f46f047 (json.hpp)
61e605be15e88deeac4582aaf01c09d616f8302edde7adcaba9261ddc3b4ceca (include.zip)

Summary
This release is made days after the 3.10.1 release due to a bug in the release script:
The 3.10.1 release at GitHub contained the correct files,
but the associated tag v3.10.1 points to the wrong commit.
This release is made with a fixed build script. All changes are backward-compatible.

Improvements
Fix the release scripts to correctly tag releases. nlohmann/json#2973
Fix some -Wunused warnings on JSON_DIAGNOSTICS when the library is built without CMake.
nlohmann/json#2975
nlohmann/json#2976

Deprecated functions
Passing iterator pairs or pointer/length pairs to parsing functions
(basic_json::parse, basic_json::accept, basic_json::sax_parse, basic_json::from_cbor,
basic_json::from_msgpack, basic_json::from_ubjson, basic_json::from_bson)
via initializer lists is deprecated.
Instead, pass two iterators; for instance, call basic_json::from_cbor(ptr, ptr+len)
instead of basic_json::from_cbor({ptr, len}).

-License-Update: Copyright year updated to 2021.

Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
daregit pushed a commit to daregit/yocto-combined that referenced this issue May 22, 2024
@wangmingyu84 @kraj
src/meta-openembedded:nlohmann-json: upgrade 3.9.1 -> 3.10.2
1a2e8b1 
Release date: 2021-08-26
SHA-256: 059743e48b37e41579ee3a92e82e984bfa0d2a9a2b20b175d04db8089f46f047 (json.hpp)
61e605be15e88deeac4582aaf01c09d616f8302edde7adcaba9261ddc3b4ceca (include.zip)

Summary
This release is made days after the 3.10.1 release due to a bug in the release script:
The 3.10.1 release at GitHub contained the correct files,
but the associated tag v3.10.1 points to the wrong commit.
This release is made with a fixed build script. All changes are backward-compatible.

Improvements
Fix the release scripts to correctly tag releases. nlohmann/json#2973
Fix some -Wunused warnings on JSON_DIAGNOSTICS when the library is built without CMake.
nlohmann/json#2975
nlohmann/json#2976

Deprecated functions
Passing iterator pairs or pointer/length pairs to parsing functions
(basic_json::parse, basic_json::accept, basic_json::sax_parse, basic_json::from_cbor,
basic_json::from_msgpack, basic_json::from_ubjson, basic_json::from_bson)
via initializer lists is deprecated.
Instead, pass two iterators; for instance, call basic_json::from_cbor(ptr, ptr+len)
instead of basic_json::from_cbor({ptr, len}).

-License-Update: Copyright year updated to 2021.

Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nlohmann nlohmann

Labels
confirmed kind: bug release item: 🔨 further change solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Projects
None yet
Milestone
Release 3.10.2
Development

Successfully merging a pull request may close this issue.

Properly set and push version tags nlohmann/json_release_scripts
4 participants
@nlohmann @dvzrv @xvitaly @Andreas-Schniertshauer