-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GCC 13 build failures #3927
Comments
But there's another one with the MR above applied (gcc 13 snapshot 20230122):
|
Hello, Any update on this? |
No. And since we're using GCC 13.0 in our CI as well, I have no idea how to fix this. |
Does it? I may be missing something looking at the jobs, but it looks to me only <=12 is tested, |
Yes, you seem to be right. |
Any update? 🤔 |
I am folloing as well. Gcc 13 is coming with Fedora 38 and I would like to be able to compile this library on it |
I am currently traveling. If anyone wants to help it would be great. First step would be adding GCC 13 to the CI. |
trofi fixed half of this problem in #3895, I'm working on the other half, and it should be done within a few minutes |
This fixes a build error on GCC 13: /home/arsen/nlohmann_json/tests/src/unit-iterators2.cpp: In function ‘void _DOCTEST_ANON_FUNC_2()’: /home/arsen/nlohmann_json/tests/src/unit-iterators2.cpp:946:32: error: no match for ‘operator==’ (operand types are ‘doctest::detail::Expression_lhs<std::ranges::reverse_view<std::ranges::ref_view<nlohmann::json_abi_v3_11_2::basic_json<> > >&>’ and ‘nlohmann::json_abi_v3_11_2::json’ {aka ‘nlohmann::json_abi_v3_11_2::basic_json<>’}) 946 | CHECK(reversed == j_expected); | ^~ ~~~~~~~~~~ | | | nlohmann::json_abi_v3_11_2::json {aka nlohmann::json_abi_v3_11_2::basic_json<>} Bug: https://bugs.gentoo.org/895692 Closes: nlohmann#3927
WDYT of releasing |
+1 to next release. GCC 13 is the default system compiler on newer distros, so right now this library will not build on e.g. current Ubuntu. |
I am currently having issues running my release script. I will create a bug issue and ask for help bringing this forward. |
This: #4197 |
Description
Build failure under GCC 13.
Reproduction steps
Run standard build with tests enabled against GCC 13.
Expected vs. actual results
Minimal code example
No response
Error messages
Compiler and operating system
GCC 13.0.0, Fedora Linux 38
Library version
3.11.2
Validation
develop
branch is used.The text was updated successfully, but these errors were encountered: