Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1213 #1214

Merged
merged 1 commit into from
Aug 24, 2018
Merged

Fix #1213 #1214

merged 1 commit into from
Aug 24, 2018

Conversation

simnalamburt
Copy link
Contributor

Please review this patch!

Fixes #1213

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling aada309 on devsisters:fix-1213 into 359f98d on nlohmann:develop.

@nlohmann nlohmann self-assigned this Aug 24, 2018
nlohmann
nlohmann approved these changes Aug 24, 2018
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann added this to the Release 3.2.1 milestone Aug 24, 2018
@nlohmann nlohmann merged commit 04597c3 into nlohmann:develop Aug 24, 2018
@nlohmann
Copy link
Owner

Thanks @simnalamburt for the quick response and @RalfBielig for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalfBielig RalfBielig RalfBielig approved these changes

@nlohmann nlohmann nlohmann approved these changes

Assignees

@nlohmann nlohmann

Labels
None yet
Projects
None yet
Milestone
Release 3.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@simnalamburt @coveralls @nlohmann @RalfBielig