Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Hedley to v11. #1799

Merged
merged 1 commit into from
Oct 17, 2019
Merged

Update Hedley to v11. #1799

merged 1 commit into from
Oct 17, 2019

Conversation

nemequ
Copy link
Contributor

@nemequ nemequ commented Oct 16, 2019 •
edited
Loading

I just released version 11 of Hedley, largely to address nemequ/hedley#28. This just pulls in the latest release.

Pull request checklist

Read the Contribution Guidelines for detailed information.

  • Changes are described in the pull request, or an existing issue is referenced.
  • The test suite compiles and runs without error.
  • Code coverage is 100%. Test cases can be added by editing the test suite.
  • The source code is amalgamated; that is, after making changes to the sources in the include/nlohmann directory, run make amalgamate to create the single-header file single_include/nlohmann/json.hpp. The whole process is described here.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling fbcbc76 on nemequ:develop into ed55414 on nlohmann:develop.

nlohmann
nlohmann approved these changes Oct 17, 2019
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann self-assigned this Oct 17, 2019
@nlohmann nlohmann added this to the Release 3.7.1 milestone Oct 17, 2019
@nlohmann nlohmann merged commit 4c06191 into nlohmann:develop Oct 17, 2019
@nlohmann
Copy link
Owner

Thanks!

@nlohmann
Copy link
Owner

🔖 Release item

This issue/PR will be part of the next release of the library. This template helps preparing the release notes.

Type

  • ✨ New Feature
  • 🐛 Bug Fix
  • ⚡️ Improvement
  • 🔨 Further Change
  • 🔥 Deprecated function

Description

  • Update to Hedley v11 to fix an issue with MSVC's IntelliSense.

This was referenced Oct 17, 2019
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlohmann nlohmann nlohmann approved these changes

Assignees

@nlohmann nlohmann

Labels
release item: 🐛 bug fix
Projects
None yet
Milestone
Release 3.7.1
Development

Successfully merging this pull request may close these issues.
3 participants
@nemequ @coveralls @nlohmann