Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #1805 #1806

Merged
merged 1 commit into from
Nov 1, 2019
Merged

Fix issue #1805 #1806

merged 1 commit into from
Nov 1, 2019

Conversation

cbegue
Copy link
Contributor

@cbegue cbegue commented Oct 21, 2019

  • Add some restriction on pair partial specialization of to_json

Signed-off-by: Camille Bégué camille.begue.pro@gmail.com

@coveralls
Copy link

coveralls commented Oct 21, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 794a3d4 on cbegue:develop into f272ad5 on nlohmann:develop.

nlohmann
nlohmann requested changes Oct 27, 2019
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have a small remark on the test case.

test/src/unit-udt.cpp Outdated Show resolved Hide resolved
@cbegue
Fix issue #1805
794a3d4 
 * Add some restriction on pair partial specialization of to_json

Signed-off-by: Camille Bégué <camille.begue.pro@gmail.com>
nlohmann
nlohmann reviewed Nov 1, 2019
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann self-assigned this Nov 1, 2019
@nlohmann nlohmann added this to the Release 3.7.1 milestone Nov 1, 2019
@nlohmann nlohmann merged commit a1828bb into nlohmann:develop Nov 1, 2019
@nlohmann
Copy link
Owner

nlohmann commented Nov 1, 2019

Thanks!

@nlohmann
Copy link
Owner

nlohmann commented Nov 1, 2019

🔖 Release item

This issue/PR will be part of the next release of the library. This template helps preparing the release notes.

Type

  • ✨ New Feature
  • 🐛 Bug Fix
  • ⚡️ Improvement
  • 🔨 Further Change
  • 🔥 Deprecated function

Description

  • Fixed the specialization for conversions from pairs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlohmann nlohmann nlohmann approved these changes

Assignees

@nlohmann nlohmann

Labels
release item: 🐛 bug fix
Projects
None yet
Milestone
Release 3.7.1
Development

Successfully merging this pull request may close these issues.
3 participants
@cbegue @coveralls @nlohmann