-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
catch exceptions for json_pointer : ..../+99 #1990
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
Could you please review the lines that became uncovered (https://coveralls.io/builds/29418441/source?filename=include%2Fnlohmann%2Fdetail%2Fjson_pointer.hpp#L418) and check if you could add a respective test?
@nlohmann |
@dota17 |
Sorry, i had been busy for the past few days. |
@nlohmann |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Thanks! |
🔖 Release itemThis issue/PR will be part of the next release of the library. This template helps preparing the release notes. Type
Description
|
From RFC 6901, Section 4:
The array index must not begin with signed char either.
Currently, the path
.../+99
works, and it maybe not right.