-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR for #2006 to test in AppVeyor. #2008
Conversation
Sure enough, the AppVeyor Visual Studio 2015 build and test job passed. Either the tests are not sufficient to demonstrate the original problem, or it has been independently fixed by other changes (or a VS 2015 update?). |
Looking at https://ci.appveyor.com/project/nlohmann/json/builds/31680408/job/s1dryqoqfjcehkln gives So I think this is ready to go. |
I had checked and tested in my fork repo. |
I can confirm that this fixes the issue for us, so we can build 3.7.3 after applying this PR with VS2019 release 5.2. Thanks! |
Dear admins, I think the Travis build report is incorrect. In the details I see all jobs as completed and one failed. However this page still lists Travis as "pending". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Thanks! |
🔖 Release itemThis issue/PR will be part of the next release of the library. This template helps preparing the release notes. Type
Description
|
PR for #2006 to test in AppVeyor as requested by @t-b.
Pull request checklist
Read the Contribution Guidelines for detailed information.
include/nlohmann
directory, runmake amalgamate
to create the single-header filesingle_include/nlohmann/json.hpp
. The whole process is described here.