Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue 2112 #2137

Merged
merged 1 commit into from
May 27, 2020
Merged

Fix issue 2112 #2137

merged 1 commit into from
May 27, 2020

Conversation

dota17
Copy link
Contributor

@dota17 dota17 commented May 26, 2020

This little patch is to fix issue #2112.

@dota17 dota17 requested a review from nlohmann as a code owner May 26, 2020 11:47
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling eb50fbf on dota17:MSC_VER into 3c60a66 on nlohmann:develop.

@nlohmann nlohmann linked an issue May 27, 2020 that may be closed by this pull request
Possible incorrect _MSC_VER reference #2112
Closed
nlohmann
nlohmann approved these changes May 27, 2020
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann self-assigned this May 27, 2020
@nlohmann nlohmann added this to the Release 3.8.0 milestone May 27, 2020
@nlohmann nlohmann merged commit d70d06a into nlohmann:develop May 27, 2020
@nlohmann
Copy link
Owner

Thanks!

@nlohmann
Copy link
Owner

🔖 Release item

This issue/PR will be part of the next release of the library. This template helps preparing the release notes.

Type

  • ✨ New Feature
  • 🐛 Bug Fix
  • ⚡️ Improvement
  • 🔨 Further Change
  • 🔥 Deprecated function

Description

@dota17 dota17 deleted the MSC_VER branch May 27, 2020 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlohmann nlohmann nlohmann approved these changes

Assignees

@nlohmann nlohmann

Labels
release item: 🔨 further change
Projects
None yet
Milestone
Release 3.8.0
Development

Successfully merging this pull request may close these issues.

Possible incorrect _MSC_VER reference
3 participants
@dota17 @coveralls @nlohmann