added inline to NLOHMANN_DEFINE_TYPE_NON_INTRUSIVE macro #2306
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
just a tiny pull request here.
I tried out the DEFINE_TYPE macros and noticed that the functions defined by the
NLOHMANN_DEFINE_TYPE_NON_INTRUSIVE
macro weren't markedinline
. I could find no reason why they cannot be inline or why forcing users to manually declare the to/from_json functions would be helpful, so I simply added theinline
.Cheers,
Jonas
include/nlohmann
directory, runmake amalgamate
to create the single-header filesingle_include/nlohmann/json.hpp
. The whole process is described here.