Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added inline to NLOHMANN_DEFINE_TYPE_NON_INTRUSIVE macro #2306

Merged
merged 2 commits into from
Jul 25, 2020

Conversation

jwittbrodt
Copy link
Contributor

Hey,

just a tiny pull request here.

I tried out the DEFINE_TYPE macros and noticed that the functions defined by the NLOHMANN_DEFINE_TYPE_NON_INTRUSIVE macro weren't marked inline. I could find no reason why they cannot be inline or why forcing users to manually declare the to/from_json functions would be helpful, so I simply added the inline.

Cheers,
Jonas


  • Changes are described in the pull request, or an existing issue is referenced.
  • The test suite compiles and runs without error.
  • Code coverage is 100%. Test cases can be added by editing the test suite.
  • The source code is amalgamated; that is, after making changes to the sources in the include/nlohmann directory, run make amalgamate to create the single-header file single_include/nlohmann/json.hpp. The whole process is described here.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 0f22ed0 on jwittbrodt:develop into 43e07bb on nlohmann:develop.

Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann merged commit a1dbfcd into nlohmann:develop Jul 25, 2020
@nlohmann
Copy link
Owner

Thanks!

@nlohmann
Copy link
Owner

nlohmann commented Jul 25, 2020


🔖 Release item

This issue/PR will be part of the next release of the library. This template helps preparing the release notes.

Type

  • ✨ New Feature
  • 🐛 Bug Fix
  • ⚡️ Improvement
  • 🔨 Further Change
  • 🔥 Deprecated function

Description


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants