Fix code to work without exceptions #2347
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression introduced in #2206: container
ordered_map
throws exceptions viathrow
instead of macroJSON_THROW
which breaks the possibility to compile the code with-fno-exceptions
. The reason this bug was not detected earlier is that we have no step in the CI that sets the flags-fno-exceptions
, but only relies on the CMake flagJSON_NoExceptions
. As a consequence, we added a test to compile a simple binary with-fno-exceptions
set.