Fix move constructor of json_ref #2405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is also a better solution: karzhenkov/json@42a9dc0. I'm ready to force-push if it's acceptable. |
|
@karzhenkov That would be great! |
karzhenkov
force-pushed
the
fix-json_ref-move
branch
from
d81be55
to
42a9dc0
Compare
|
Thanks! |
|
Great catch @karzhenkov, didn't expect #2387 to be a bug. |
|
Sorry everybody for waiting so long, and thanks for your patience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The defaulted move constructor of
nlohmann::detail::json_refmakes copy of internal pointer which points to a field inside the object being moved. It becomes a dangling pointer. A "manual" move implementation is needed.Resolves #2387. Here is an example at Godbolt.