Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove HEDLEY annotation from exception::what() #2673

Merged
merged 1 commit into from
Mar 23, 2021
Merged

Remove HEDLEY annotation from exception::what() #2673

merged 1 commit into from
Mar 23, 2021

Commits on Mar 16, 2021

  1. Remove HEDLEY annotation from exception::what()

    The latest MSVC compiler throws the following warning on
    nlohmann::detail::exception::what() if /analyze is enabled:
    
    ```
    vcruntime_exception.h(93) : warning C28204: 'what' has an override at
    `nlohmann\json\develop\single_include\nlohmann\json.hpp(2644)`
    and only the override is annotated for return: when an override is
    annotated, the base (this function) should be similarly annotated.
    ```
    
    See https://godbolt.org/z/r331h4
    remyjette committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    0a9ec38 View commit details
    Browse the repository at this point in the history