-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix assertion failure for JSON_DIAGNOSTICS #3037
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlsmedstad
changed the title
Fix assertion failure for JSON_DIAGNOSTICS #3032
Fix assertion failure for JSON_DIAGNOSTICS
Sep 27, 2021
carlsmedstad
force-pushed
the
issue3032
branch
from
September 27, 2021 18:53
f397f40
to
1195701
Compare
gregmarr
reviewed
Sep 27, 2021
gregmarr
approved these changes
Sep 27, 2021
nlohmann
requested changes
Sep 28, 2021
Additionally, add the previously failing case to the test suite.
carlsmedstad
force-pushed
the
issue3032
branch
from
September 28, 2021 07:18
39b8d2c
to
80688bd
Compare
Was there something more you wanted me to do on this before merging, @nlohmann? |
I'll check tomorrow. |
nlohmann
approved these changes
Oct 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decided to give it a go. Not super well-versed in template programming and such but this does at least pass my test case.
Resolves #3032.
Pull request checklist
Read the Contribution Guidelines for detailed information.
include/nlohmann
directory, runmake amalgamate
to create the single-header filesingle_include/nlohmann/json.hpp
. The whole process is described here.Please don't
#ifdef
s or other means.