-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate documentation #3071
Conversation
Assuming I understand this right and the documentation is still in the distribution, just not in the header file, should the comment with the link to the latest documentation also contain the path to the documentation for this version? I still see utility in being able to see the documentation as it was written at the time that the version I'm using was released. Will the documentation site still contain the documentation for any functions that are removed with v4 comes out and several of the deprecated functions are removed? |
Good point! The motivation for this PR is the observation that the documentation in the code and that in the docs folder start to diverge. Furthermore, Doxygen is so inflexible that the current output is ugly and needs a lot of repetitions in the code. That said, I want to drop Doxygen. As the Maybe (?) there is also a way to have URLs like https://json.nlohmann.me/v3.10.3/api/basic_json/accept/ or so that contain the documentation for a specific version. |
I agree that Doxygen isn't the greatest. :) This may not be sufficient for people that only use it as a submodule tagged to a specific commit. The direct file links would still be helpful there, and would also make it easier for maintainers to update the docs when they make changes. Maybe it would be enough to have a single comment at the top that describes how to convert from a URL to docs folder location. |
…_doxygen � Conflicts: � doc/Doxyfile � doc/examples/README.link
…_doxygen � Conflicts: � include/nlohmann/json.hpp � single_include/nlohmann/json.hpp
…_doxygen � Conflicts: � include/nlohmann/detail/input/input_adapters.hpp � include/nlohmann/json.hpp � single_include/nlohmann/json.hpp
@nlohmann The consolidated docs looks great. Just wanted to point out that there are some stale links/references to the doxygen docs in the main README: https://github.com/nlohmann/json/blob/develop/README.md?plain=1#:~:text=doxygen |
This PR consolidates two streams of documentation: Doxygen-style comments in the source code and the newer MkDocs-based Markdown documentation in folder
doc/mkdocs
. Both documentations diverged over time, and since we reached the limits of what Doxygen can do, we decided to drop Doxygen and go all-in on MkDocs. As a result, we removed all Doxygen-style comments for the public API and updated/fixed the MkDocs accordingly. The result is a much cleaner documentation that documents all overloads of functions with the same name on the same page.In particular:
doc/images
todoc/mkdocs/images