Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add assertion for invariant in SAX-DOM parser #3498

Merged
merged 1 commit into from
May 19, 2022
Merged

Add assertion for invariant in SAX-DOM parser #3498

merged 1 commit into from
May 19, 2022

Conversation

nlohmann
Copy link
Owner

Add assertions to catch misbehavior detected with #3490.

@nlohmann nlohmann marked this pull request as draft May 17, 2022 08:55
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling d5e34ec on sax_dom_assertions into a8a547d on develop.

This was referenced May 17, 2022
Closed
Closed
@nlohmann nlohmann marked this pull request as ready for review May 17, 2022 20:45
@nlohmann
Copy link
Owner Author

I would merge this once #3500 is merged and OSS-Fuzz confirms the related issues as closed.

(If I would merge it now, OSS-Fuzz would likely just find the same issues as triggering the assertions.)

This was referenced May 18, 2022
Merged
Merged
@nlohmann nlohmann added this to the Release 3.11.0 milestone May 19, 2022
@nlohmann nlohmann merged commit 6ff2ea3 into develop May 19, 2022
@nlohmann nlohmann deleted the sax_dom_assertions branch May 19, 2022 17:56
@nlohmann nlohmann mentioned this pull request May 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release item: 🔨 further change
Projects
None yet
Milestone
Release 3.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nlohmann @coveralls