Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: fix "JSON_MultipleHeaders" option spelling #3555

Merged
merged 1 commit into from
Jun 25, 2022
Merged

CI: fix "JSON_MultipleHeaders" option spelling #3555

merged 1 commit into from
Jun 25, 2022

Conversation

karzhenkov
Copy link
Contributor

@karzhenkov karzhenkov commented Jun 25, 2022 •
edited
Loading

Due to a typo, the test ci_test_single_header uses actually multiple headers.

@request-info
Copy link

request-info bot commented Jun 25, 2022

We would appreciate it if you could provide us with more info about this issue or pull request! Please check the issue template and the pull request template.

@request-info request-info bot added the state: needs more info the author of the issue needs to provide more details label Jun 25, 2022
falbrechtskirchinger
falbrechtskirchinger approved these changes Jun 25, 2022
View reviewed changes
Copy link
Contributor

@falbrechtskirchinger falbrechtskirchinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 648d47a on karzhenkov:fix-ci_test_single_header into 39e2768 on nlohmann:develop.

@nlohmann nlohmann removed the state: needs more info the author of the issue needs to provide more details label Jun 25, 2022
nlohmann
nlohmann approved these changes Jun 25, 2022
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann added this to the Release 3.11.0 milestone Jun 25, 2022
@nlohmann nlohmann self-assigned this Jun 25, 2022
@nlohmann nlohmann merged commit 954b10a into nlohmann:develop Jun 25, 2022
@nlohmann
Copy link
Owner

Thanks! Good catch indeed!

@karzhenkov karzhenkov deleted the fix-ci_test_single_header branch June 25, 2022 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@falbrechtskirchinger falbrechtskirchinger falbrechtskirchinger approved these changes

@nlohmann nlohmann nlohmann approved these changes

Assignees

@nlohmann nlohmann

Labels
release item: 🔨 further change
Projects
None yet
Milestone
Release 3.11.0
Development

Successfully merging this pull request may close these issues.
4 participants
@karzhenkov @coveralls @nlohmann @falbrechtskirchinger