Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust naming of GitHub action jobs #3661

Merged
merged 1 commit into from
Aug 3, 2022
Merged

Adjust naming of GitHub action jobs #3661

merged 1 commit into from
Aug 3, 2022

Conversation

nlohmann
Copy link
Owner

@nlohmann nlohmann commented Aug 3, 2022

Job names in GitHub Actions should begin with a capital letter to harmonize the appearance when using default recipes like checkout.

@nlohmann nlohmann added the review needed It would be great if someone could review the proposed changes. label Aug 3, 2022
@nlohmann nlohmann removed the review needed It would be great if someone could review the proposed changes. label Aug 3, 2022
falbrechtskirchinger
falbrechtskirchinger approved these changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@falbrechtskirchinger falbrechtskirchinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you know this has been bugging me? Thanks! ;-)

Looks good to me.

@nlohmann nlohmann added this to the Release 3.11.2 milestone Aug 3, 2022
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 214b472 on captialize_job_names into 2ac7d02 on develop.

@nlohmann nlohmann merged commit 22cd1c9 into develop Aug 3, 2022
@nlohmann nlohmann deleted the captialize_job_names branch August 3, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregmarr gregmarr gregmarr approved these changes

@falbrechtskirchinger falbrechtskirchinger falbrechtskirchinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 3.11.2
Development

Successfully merging this pull request may close these issues.
4 participants
@nlohmann @coveralls @falbrechtskirchinger @gregmarr