Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix labeler permissions #3674

Merged

Conversation

falbrechtskirchinger
Copy link
Contributor

Change trigger to pull_request_target for write permissions and limit permissions to minimum required.

@nlohmann
Copy link
Owner

nlohmann commented Aug 4, 2022

The job seems not to be executed.

@falbrechtskirchinger
Copy link
Contributor Author

I don't think this will trigger until it's merged.

Testing here. I've pushed it to develop and submitted a PR. (Of course, we have the same issue of not being able to test permissions this way.)
falbrechtskirchinger#1

@falbrechtskirchinger
Copy link
Contributor Author

All I can say is that it runs (once merged). If it improves the situation over the status-quo of not labeling PRs, I don't know.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 12819cf on falbrechtskirchinger:labeler-permissions into 500bdc5 on nlohmann:develop.

@nlohmann
Copy link
Owner

nlohmann commented Aug 4, 2022

Let's give it a try!

Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann added this to the Release 3.11.2 milestone Aug 4, 2022
@nlohmann nlohmann merged commit 01af734 into nlohmann:develop Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants