-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ordered map remove duplicate codes #4057
Open
Tomerkm
wants to merge
12
commits into
nlohmann:develop
Choose a base branch
from
Tomerkm:ordered_map_remove_duplicate_codes
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Ordered map remove duplicate codes #4057
Tomerkm
wants to merge
12
commits into
nlohmann:develop
from
Tomerkm:ordered_map_remove_duplicate_codes
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… that were missing: 1. iota 2. copy 3. copy if 4. copy n
make amalgamat
🔴 Amalgamation check failed! 🔴The source code has not been amalgamated. @Tomerkm |
nlohmann
requested changes
Sep 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please amalagamate the source code.
(Also, please update from the develop branch as it has a working CI now.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Describe your pull request here. Please read the text below the line, and make sure you follow the checklist.]
I removed the code at the function:
std::pair<iterator, bool> emplace(const key_type& key, T&& t)
and replaced which a method that exists at the class and do the job.
The method find do the same as the iterate at the code does.
Instead of writing the same code, I have called the method find.
The idea is to use the function does the job instead of rewriting the same code.
I want to see if this ok before I change on the others.
Pull request checklist
Read the Contribution Guidelines for detailed information.
include/nlohmann
directory, runmake amalgamate
to create the single-header filessingle_include/nlohmann/json.hpp
andsingle_include/nlohmann/json_fwd.hpp
. The whole process is described here.Please don't
#ifdef
s or other means.