-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing assignement for iterator wrapper second, and adding unit test #579
Fixing assignement for iterator wrapper second, and adding unit test #579
Conversation
Running the test cases, I get:
The new |
As Travis is sometimes buggy, I restarted the failing tests (see https://travis-ci.org/nlohmann/json/builds/230863073), but I fear that there is a problem with Clang, but also newer GCC versions. |
Travis came to the same results: all compilers but GCC 4.9 fail, see see https://travis-ci.org/nlohmann/json/builds/230863073. |
I see. I'll look into it. This it probably a good case for |
|
I'm getting Clang to see if I can fix this issue. I may have to generate a reverse patch to remove the code (apparently, it's not supported by all compilers). |
Clang seems to be happy after making the compares const. |
The unit tests succeed now. Great! I'll merge this tonight. |
To complete #350 and #578, this PR adds an assignment operator and a new unit test for the iterator wrapper functionality with .first and .second.