Fix warning C4706 on Visual Studio 2017 #785
Conversation
This causes test-udt to crash due to bad iterator
|
Can one of the admins verify this patch? |
Lots of tests have this warning. Also moved out of for loop, doesn't need to be done every loop.
|
@trilogy-service-ro Could you please stop adding automated comments to every PR of this project? Of course, we have a look at each patch. |
| @@ -66,6 +66,19 @@ set_target_properties(catch_main PROPERTIES | |||
| ) | |||
| target_include_directories(catch_main PRIVATE "thirdparty/catch") | |||
|
|
|||
| # https://stackoverflow.com/questions/2368811/how-to-set-warning-level-in-cmake | |||
| if(MSVC) | |||
| # Force to always compile with W4 | |||
There was a problem hiding this comment.
Why do you want to force the /W4 flag?
There was a problem hiding this comment.
With /W4 always enabled we can ensure no warnings will be emitted when adding this library to an existing project. It feels like a library such as this one should support /W4 with no issues. There are other warnings in unit tests even with /W3, but that would be for another PR. At least there is visibility now.
There was a problem hiding this comment.
Ok, thanks. I realized we're up to some 50 warnings now...
There was a problem hiding this comment.
I would really appreciate any help with MSVC regarding this warnings, as I have no experience here.
|
Thanks a lot! |
I'm pretty sure the logic is the same, just moves out the updating of variable
keep. All tests pass at least.This also fixes a bug in
unit-udtwhich has a missingu8causing crashes on windows (due to iterator assert)