fix sfinae on basic_json UDT constructor #919
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a compiler error today while playing with
basic_json
and incomplete types, an error similar to the following happened:Indeed,
std::is_base_of
requires the second type to be complete.I refactored the existing checks to put them in
detail/meta.hpp
.The use of
detail::conjunction
is mandatory to short-circuit the template evaluation.Pull request checklist
Read the Contribution Guidelines for detailed information.
develop
directory, runmake amalgamate
to create the single-header filesrc/json.hpp
. The whole process is described here.Please don't
#ifdef
s or other means.