Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sfinae on basic_json UDT constructor #919

Merged

Conversation

theodelrieu
Copy link
Contributor

@theodelrieu theodelrieu commented Jan 17, 2018

I had a compiler error today while playing with basic_json and incomplete types, an error similar to the following happened:

invalid use of incomplete type in std::is_base_of

Indeed, std::is_base_of requires the second type to be complete.

I refactored the existing checks to put them in detail/meta.hpp.
The use of detail::conjunction is mandatory to short-circuit the template evaluation.

Pull request checklist

Read the Contribution Guidelines for detailed information.

  • Changes are described in the pull request, or an existing issue is referenced.
  • The test suite compiles and runs without error.
  • Code coverage is 100%. Test cases can be added by editing the test suite.
  • The source code is amalgamated; that is, after making changes to the sources in the develop directory, run make amalgamate to create the single-header file src/json.hpp. The whole process is described here.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.8 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Specifically, I am aware of compilation problems with Microsoft Visual Studio (there even is an issue label for these kind of bugs). I understand that even in 2016, complete C++11 support isn't there yet. But please also understand that I do not want to drop features or uglify the code just to make Microsoft's sub-standard compiler happy. The past has shown that there are ways to express the functionality such that the code compiles with the most recent MSVC - unfortunately, this is not the main objective of the project.
  • Please refrain from proposing changes that would break JSON conformance. If you propose a conformant extension of JSON to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

Avoid compiler errors when performing SFINAE checks on basic_json
and incomplete types.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling dcee778 on theodelrieu:fix/sfinae_for_incomplete_types into 3ac6745 on nlohmann:develop.

Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann self-assigned this Jan 23, 2018
@nlohmann nlohmann added this to the Release 3.1.0 milestone Jan 23, 2018
@nlohmann nlohmann merged commit f5c4e9f into nlohmann:develop Jan 23, 2018
@nlohmann
Copy link
Owner

Thanks!

@theodelrieu theodelrieu deleted the fix/sfinae_for_incomplete_types branch January 23, 2018 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants