Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use SimpleGoodTuring as a default for NgramModel #603

Closed
kmike opened this issue Feb 11, 2014 · 1 comment
Closed

Don't use SimpleGoodTuring as a default for NgramModel #603

kmike opened this issue Feb 11, 2014 · 1 comment
Labels
language-model

Comments

@kmike
Copy link
Member

kmike commented Feb 11, 2014

See #602 (comment) for motivation. Since this change is backwards-incompatible I think it is better to fix it before NLTK 3 is released.
@kmike kmike modified the milestones: nltk3 final, nltk3beta Feb 11, 2014
stevenbird added a commit that referenced this issue Feb 20, 2014
@stevenbird
removed ngram model package, pending resolution of issues #133, #157, #…
73f7e7b 
…167, #367, #380, #388, #396, #602, #603; package saved in a new branch
@stevenbird stevenbird removed this from the nltk3beta milestone Feb 20, 2014
inteldict pushed a commit to inteldict/nltk that referenced this issue Jul 15, 2015
@stevenbird
removed ngram model package, pending resolution of issues nltk#133, n…
052b5ab 
…ltk#157, nltk#167, nltk#367, nltk#380, nltk#388, nltk#396, nltk#602, nltk#603; package saved in a new branch
@iliakur
Copy link
Contributor

iliakur commented Aug 13, 2019

@stevenbird I think we can close this because the new language model module doesn't really have a "default" model and the underlying problem with SGT can be tracked in #602.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
language-model
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stevenbird @kmike @iliakur