Add BMS Support for grib1 files #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the ability to consider Bitmap Section(BMS) in Grib1Reader while reading data by revising the 'ReadRecordRawData' method. Added 'Test_ReadWithBms' unit test to verify the new capability. Added '.idea/' to .gitignore to exclude JetBrains IDE files.
|
Everything looks good. Thank you for your contribution ! |
|
Thanks for reviewing and pushing a package, it is much appreciated :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds support for grib1 files with a BMS section, along with a test.
I have run all unit tests, and all pass.
Issues
Fixes #9