Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infer user nixpkgs commit #19

Closed
nmattia opened this issue Feb 16, 2019 · 2 comments
Closed

Infer user nixpkgs commit #19

nmattia opened this issue Feb 16, 2019 · 2 comments
Labels
wontfix This will not be worked on

Comments

@nmattia
Copy link
Owner

nmattia commented Feb 16, 2019

The feature I miss at first is that the default pin isn't related to my NIX_PATH at all. It would be nice (for me) if the tool consulted NIX_PATH and set the pin from the commit my current nixpkgs checkout is at.

I'm not very familiar with NIX_PATH. Mine is set like this:

$ echo $NIX_PATH 
nixpkgs=https://api.github.com/repos/NixOS/nixpkgs-channels/tarball/168cbb39691cca2822ce1fdb3e8c0183af5c6d0d

but I'm guessing most people use channels and the like. Is there a list of the allowed formats, and what people usually have in there?

@mpickering
Copy link

I think some heuristics will have to be used. My NIX_PATH points to a local directory where nixpkgs is checked out. So in order to infer a pin the program would have to try to find out what commit it was checked out at and then try to find that commit in one of the remotes.

In your case as you already link to a tarball then that could be used directly.

I'm not sure how channels work exactly.

@erictapen
Copy link

I'm also using a local checkout of Nixpkgs with some custom changes ontop and it would be great if niv could use it like I do it with NIX_PATH. Uncommited changes in Nixpkgs would still have an effect.

@nmattia nmattia added the wontfix This will not be worked on label Jul 15, 2020
@andir andir closed this as completed Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

4 participants