New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coerce Int ids to String #159

Open

chrisjenkins wants to merge 2 commits into nmdias:master from chrisjenkins:master

chrisjenkins commented May 13, 2024

According to the JSON Feed specification (https://www.jsonfeed.org/version/1/), item ids should be coerced to strings:

id (required, string) is unique for that item for that feed over time. If an item is ever updated, the id should be unchanged. New items should never use a previously-used id. If an id is presented as a number or other type, a JSON Feed reader must coerce it to a string

The init method is thus changed to detect an invalid encoding and try an alternate type instead.

chrisjenkins added 2 commits

May 13, 2024 15:34


          Try and coerce the id to a string if it is declared in the feed as an…

c97bc4b

… integer


          Delete original decoding

4eba5df

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment