Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#19] [UI] As a user, I can see the animation when loading and showing surveys #78

Merged
merged 5 commits into from
Feb 22, 2023
Merged

[#19] [UI] As a user, I can see the animation when loading and showing surveys #78

merged 5 commits into from
Feb 22, 2023

Conversation

nmint8m
Copy link
Owner

@nmint8m nmint8m commented Feb 15, 2023

What happened 👀

The user can see the animation when loading and showing surveys.

Insight 📝

When the surveyListStream is empty and the profileImageUrl is empty, then show the HomeSkeletonLoading, else show the HomeHeader.

Proof Of Work 📹

@nmint8m nmint8m added feature Feature task survey-list Feature: Survey list @0.4.0 Version 0.4.0 @0.5.0 Version 0.5.0 labels Feb 15, 2023
@nmint8m nmint8m added this to the 0.5.0 milestone Feb 15, 2023
@nmint8m nmint8m self-assigned this Feb 15, 2023
@nmint8m nmint8m temporarily deployed to staging February 15, 2023 07:03 — with GitHub Actions Inactive
@nmint8m nmint8m force-pushed the feature/17-42-api-me-integrate-profile branch from e05d4f5 to 3b6c4d3 Compare February 15, 2023 10:07
@nmint8m nmint8m temporarily deployed to staging February 15, 2023 10:08 — with GitHub Actions Inactive
@nmint8m nmint8m force-pushed the feature/17-42-api-me-integrate-profile branch from 3b6c4d3 to e8f47c6 Compare February 16, 2023 06:46
@nmint8m nmint8m temporarily deployed to staging February 16, 2023 06:47 — with GitHub Actions Inactive
@nmint8m nmint8m linked an issue Feb 16, 2023 that may be closed by this pull request
[UI] As a user, I can see the animation when loading and showing surveys #19
Closed
@nmint8m nmint8m temporarily deployed to staging February 16, 2023 08:00 — with GitHub Actions Inactive
@nmint8m nmint8m temporarily deployed to staging February 17, 2023 06:05 — with GitHub Actions Inactive
@doannimble
Copy link
Collaborator

@nmint8m Can we remove the white box background inside the loading? The UX is not friendly IMO 🙏

doannimble
doannimble reviewed Feb 20, 2023
View reviewed changes
Copy link
Collaborator

@doannimble doannimble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

lib/views/home/home_view.dart Outdated Show resolved Hide resolved
lib/views/home/skeleton_loading/home_skeleton_loading.dart Outdated Show resolved Hide resolved
lib/views/home/skeleton_loading/home_skeleton_loading.dart
width: 120,
),
SizedBox(
width: 40,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nmint8m You can use the radius properties of CirccleAvatar instead of wrapping it in a SizedBox 🙏

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be like this if I didn't wrap the CircleAvatar inside the SizedBox:

Screenshot 2023-02-22 at 14 21 12

lib/views/home/skeleton_loading/skeleton_placeholder.dart Show resolved Hide resolved
Base automatically changed from feature/17-42-api-me-integrate-profile to develop February 22, 2023 06:28
@nmint8m nmint8m temporarily deployed to staging February 22, 2023 06:28 — with GitHub Actions Inactive
@nmint8m nmint8m temporarily deployed to staging February 22, 2023 07:23 — with GitHub Actions Inactive
@nmint8m nmint8m merged commit 11c9f26 into develop Feb 22, 2023
@nmint8m nmint8m deleted the feature/19-loading-skeleton branch February 22, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manh-t manh-t manh-t approved these changes

@doannimble doannimble Awaiting requested review from doannimble doannimble is a code owner

Assignees

@nmint8m nmint8m

Labels
feature Feature task survey-list Feature: Survey list @0.4.0 Version 0.4.0 @0.5.0 Version 0.5.0
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.

[UI] As a user, I can see the animation when loading and showing surveys
3 participants
@nmint8m @doannimble @manh-t