Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for OAuth authorization #103

Merged
merged 8 commits into from
Dec 29, 2019
Merged

add support for OAuth authorization #103

merged 8 commits into from
Dec 29, 2019

Conversation

jetersen
Copy link
Collaborator

@jetersen jetersen commented Dec 28, 2019 •
edited
Loading

fixes #21

@jetersen jetersen added the tests label Dec 28, 2019
@codecov-io
Copy link

codecov-io commented Dec 28, 2019 •
edited
Loading

Codecov Report

Merging #103 into master will increase coverage by 1.85%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #103      +/-   ##
==========================================
+ Coverage   70.01%   71.86%   +1.85%     
==========================================
  Files         131      133       +2     
  Lines        1904     1930      +26     
==========================================
+ Hits         1333     1387      +54     
+ Misses        571      543      -28
Impacted Files Coverage Δ
...Client/Models/Oauth/Requests/AccessTokenRequest.cs 100% <100%> (ø)
.../GitLabApiClient/Internal/Http/GitLabHttpFacade.cs 95.55% <100%> (+29.84%) ⬆️
src/GitLabApiClient/GitLabClient.cs 100% <100%> (+28.12%) ⬆️
...ient/Models/Oauth/Responses/AccessTokenResponse.cs 100% <100%> (ø)

@jetersen jetersen changed the title fix GitLab client coverage add support for OAuth authorization Dec 28, 2019
@jetersen
Copy link
Collaborator Author

session login was removed in newer version of GitLab API: https://gitlab.com/gitlab-org/gitlab/issues/20777

@jetersen jetersen mentioned this pull request Dec 28, 2019
Closed
@jetersen jetersen closed this Dec 28, 2019
@jetersen jetersen reopened this Dec 28, 2019
@jetersen jetersen closed this Dec 28, 2019
@jetersen jetersen reopened this Dec 28, 2019
@jetersen jetersen merged commit 03a68a9 into nmklotas:master Dec 29, 2019
@jetersen jetersen deleted the fix/gitlabclientCoverage branch December 29, 2019 13:47
MindaugasLaganeckas pushed a commit to MindaugasLaganeckas/GitLabApiClient that referenced this pull request Mar 9, 2021
@jetersen @MindaugasLaganeckas
add support for OAuth authorization (nmklotas#103)
912cbbd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Oauth Bearer Token Authorization
2 participants
@jetersen @codecov-io