Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added opportunity to retrieve merge request notes and time statistics #115

Merged
merged 7 commits into from
Apr 9, 2020
Merged

Conversation

dremerdt
Copy link
Contributor

No description provided.

@jetersen
Copy link
Collaborator

jetersen commented Jan 31, 2020

Your author does not match your user you submitted the PR with: https://github.com/nmklotas/GitLabApiClient/commit/3201368e4c4bc33da879c1b02ab369bba4669d8d.patch

Also would you mind formatting the project, you can use the dotnet format tool

@codecov-io
Copy link

codecov-io commented Feb 1, 2020

Codecov Report

Merging #115 into master will decrease coverage by 0.44%.
The diff coverage is 28.12%.

@@            Coverage Diff             @@
##           master     #115      +/-   ##
==========================================
- Coverage   70.77%   70.32%   -0.45%     
==========================================
  Files         149      152       +3     
  Lines        2118     2184      +66     
==========================================
+ Hits         1499     1536      +37     
- Misses        619      648      +29
Impacted Files Coverage Δ
...l/Queries/ProjectMergeRequestsNotesQueryBuilder.cs 0% <0%> (ø)
...ls/Notes/Requests/MergeRequestNotesQueryOptions.cs 0% <0%> (ø)
...ent/Models/MergeRequests/Responses/MergeRequest.cs 88.46% <100%> (+0.46%) ⬆️
src/GitLabApiClient/GitLabClient.cs 98% <100%> (-0.74%) ⬇️
src/GitLabApiClient/MergeRequestsClient.cs 65.45% <40%> (-7.88%) ⬇️
...rgeRequests/Responses/MergeRequestTimeStatistic.cs 50% <50%> (ø)
... and 1 more

Copy link
Collaborator

@jetersen jetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me, would appreciate if you could help increase the diff coverage :)

@jetersen
Copy link
Collaborator

Would you mind resolving the conflicts?

@dremerdt
Copy link
Contributor Author

Would you mind resolving the conflicts?

Hi, resolved.

@jetersen jetersen merged commit fdb49ce into nmklotas:master Apr 9, 2020
MindaugasLaganeckas pushed a commit to MindaugasLaganeckas/GitLabApiClient that referenced this pull request Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants