Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Group Variables CRUD methods #146

Merged
merged 4 commits into from
May 30, 2020
Merged

Add Group Variables CRUD methods #146

merged 4 commits into from
May 30, 2020

Conversation

sfmskywalker
Copy link
Contributor

This PR adds support for interacting with group-level variables.

I wasn't sure whether I should add the group variable types to the Variables folder or stick them into the Groups folder, so I opted for the latter. But I'm happy to move them to the Variables folder if that has preference. If so, I suggest that we rename Variable to ProjectVariable to make a clear distinction between the two types of variables, and propagate this change wherever applicable. I'm also happy to move the stuff from Variables into the Projects folder.

Either way, it will be more consistent. Just say the word.

@codecov-io
Copy link

codecov-io commented May 2, 2020

Codecov Report

Merging #146 into master will increase coverage by 0.26%.
The diff coverage is 96.00%.

@@            Coverage Diff             @@
##           master     #146      +/-   ##
==========================================
+ Coverage   71.59%   71.85%   +0.26%     
==========================================
  Files         162      165       +3     
  Lines        2299     2324      +25     
==========================================
+ Hits         1646     1670      +24     
- Misses        653      654       +1     
Impacted Files Coverage Δ
src/GitLabApiClient/GroupsClient.cs 54.90% <90.00%> (+3.81%) ⬆️
...dels/Groups/Requests/CreateGroupVariableRequest.cs 100.00% <100.00%> (ø)
...dels/Groups/Requests/UpdateGroupVariableRequest.cs 100.00% <100.00%> (ø)
...itLabApiClient/Models/Groups/Responses/Variable.cs 100.00% <100.00%> (ø)

@jetersen jetersen merged commit 965f031 into nmklotas:master May 30, 2020
MindaugasLaganeckas pushed a commit to MindaugasLaganeckas/GitLabApiClient that referenced this pull request Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants