Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix build #156

Merged
merged 1 commit into from
May 30, 2020
Merged

fix build #156

merged 1 commit into from
May 30, 2020

Conversation

jetersen
Copy link
Collaborator

@jetersen jetersen commented May 30, 2020 •
edited
Loading

after #130 we needed some more interfaces due to other merges for the remaining things.

@jetersen jetersen added the bug label May 30, 2020
@codecov-commenter
Copy link

codecov-commenter commented May 30, 2020 •
edited
Loading

Codecov Report

Merging #156 into master will increase coverage by 0.50%.
The diff coverage is 75.23%.

@@            Coverage Diff             @@
##           master     #156      +/-   ##
==========================================
+ Coverage   70.68%   71.19%   +0.50%     
==========================================
  Files         171      169       -2     
  Lines        2439     2350      -89     
==========================================
- Hits         1724     1673      -51     
+ Misses        715      677      -38
Impacted Files Coverage Δ
src/GitLabApiClient/BranchClient.cs 33.33% <ø> (ø)
src/GitLabApiClient/CommitsClient.cs 80.00% <ø> (ø)
src/GitLabApiClient/FilesClient.cs 100.00% <ø> (ø)
...abApiClient/Internal/Queries/BranchQueryBuilder.cs 0.00% <0.00%> (ø)
...itLabApiClient/Internal/Queries/JobQueryBuilder.cs 0.00% <0.00%> (ø)
...l/Queries/ProjectMergeRequestsNotesQueryBuilder.cs 0.00% <0.00%> (ø)
...bApiClient/Internal/Queries/ReleaseQueryBuilder.cs 100.00% <ø> (ø)
...itLabApiClient/Internal/Queries/TagQueryBuilder.cs 0.00% <0.00%> (ø)
src/GitLabApiClient/IssuesClient.cs 84.61% <ø> (ø)
src/GitLabApiClient/MarkdownClient.cs 66.66% <ø> (ø)
... and 41 more

@jetersen jetersen merged commit 33a698b into nmklotas:master May 30, 2020
@jetersen jetersen deleted the fixBuild branch May 30, 2020 10:31
MindaugasLaganeckas pushed a commit to MindaugasLaganeckas/GitLabApiClient that referenced this pull request Mar 9, 2021
@jetersen @MindaugasLaganeckas
fix build (nmklotas#156)
4e8c21e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jetersen @codecov-commenter