Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable upload NuGet Preview by using GitVersion, enable sourcelink, build symbol package #81

Merged
merged 10 commits into from
Oct 29, 2019
Merged

Conversation

jetersen
Copy link
Collaborator

@jetersen jetersen commented Oct 29, 2019

  • Use Source link
  • Include/upload symbol package
  • Use GitVersion to calculate package version
  • Remove UTF-8 BOM character
  • Cleanup some old property groups of Debug/Release
  • Cleanup appveyor yml
  • Use dotnet tool to install CodeCov.tool

@codecov-io
Copy link

codecov-io commented Oct 29, 2019

Codecov Report

Merging #81 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #81   +/-   ##
=======================================
  Coverage   32.47%   32.47%           
=======================================
  Files         125      125           
  Lines        1601     1601           
=======================================
  Hits          520      520           
  Misses       1081     1081
Impacted Files Coverage Δ
...itLabApiClient/Internal/Http/GitlabApiRequestor.cs 34.54% <ø> (ø) ⬆️
...ient/Models/Issues/Responses/IssueTimeStatistic.cs 0% <ø> (ø) ⬆️
src/GitLabApiClient/BranchClient.cs 31.57% <ø> (ø) ⬆️
src/GitLabApiClient/Models/Tags/Responses/Tag.cs 0% <ø> (ø) ⬆️
src/GitLabApiClient/Models/ModifiableObject.cs 0% <ø> (ø) ⬆️
src/GitLabApiClient/TagClient.cs 42.85% <ø> (ø) ⬆️
...GitLabApiClient/Models/Releases/Responses/Asset.cs 0% <ø> (ø) ⬆️
...ation/CollectionToCommaSeparatedValuesConverter.cs 0% <ø> (ø) ⬆️
...odels/Groups/Requests/ProjectsGroupQueryOptions.cs 100% <ø> (ø) ⬆️
...bApiClient/Models/Tags/Requests/TagQueryOptions.cs 0% <ø> (ø) ⬆️
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82d8ad3...693abb9. Read the comment docs.

@jetersen jetersen changed the title Improvements Enable upload NuGet Preview by using GitVersion, enable sourcelink, build symbol package Oct 29, 2019
@jetersen jetersen merged commit ffa3ecd into nmklotas:master Oct 29, 2019
@jetersen jetersen deleted the improvements branch October 29, 2019 22:47
jetersen added a commit that referenced this pull request Oct 29, 2019
@jetersen jetersen added the chore label Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants