Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try gitlab-ce:10.1.4-ce.0 from 5 months ago. #9

Merged
merged 7 commits into from
Apr 25, 2018

Conversation

qayshp
Copy link
Contributor

@qayshp qayshp commented Apr 24, 2018

Since the build is failing, and it seems to be authentication related, try an older version of GitLab from when it may have been working.

Since the build is failing, and it seems to be authentication related, try an older version of GitLab from when it may have been working.
@qayshp
Copy link
Contributor Author

qayshp commented Apr 24, 2018

looking at https://hub.docker.com/r/gitlab/gitlab-ce/tags/ and https://github.com/nmklotas/GitLabApiClient/commits/master/docker/Dockerfile to see what the version at the time might have been

@qayshp
Copy link
Contributor Author

qayshp commented Apr 24, 2018

Unfortunately I can't see any successful builds in appveyor or travis, perhaps because they limit persistence on builds.

Edit: I do see passed builds in appveyor! https://ci.appveyor.com/project/nmklotas/gitlabapiclient/history

https://travis-ci.org/nmklotas/GitLabApiClient/builds

@qayshp qayshp closed this Apr 24, 2018
@qayshp
Copy link
Contributor Author

qayshp commented Apr 24, 2018

Well, it changed the 401s I was seeing to 404s in Travis.
https://travis-ci.org/nmklotas/GitLabApiClient/builds/370794608 404 for project not found versus 401 unauthorized in https://travis-ci.org/nmklotas/GitLabApiClient/builds/370778025

@qayshp qayshp reopened this Apr 24, 2018
@codecov-io
Copy link

codecov-io commented Apr 24, 2018

Codecov Report

Merging #9 into master will increase coverage by 2.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
+ Coverage   25.02%   27.15%   +2.13%     
==========================================
  Files          68       58      -10     
  Lines        1099      961     -138     
  Branches       94       94              
==========================================
- Hits          275      261      -14     
+ Misses        759      635     -124     
  Partials       65       65
Impacted Files Coverage Δ
Owner.cs
UpdateProjectRequest.cs
ProjectQueryOptions.cs
Statistics.cs
Namespace.cs
Project.cs
CreateProjectRequest.cs
Permissions.cs
Access.cs
Links.cs

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e26242...dc4513e. Read the comment docs.

@qayshp
Copy link
Contributor Author

qayshp commented Apr 24, 2018

Sorry for the spam here; I'm pushing here to test my changes on the travis and appveyor setup for PRs. I should set that up for my fork and test there.

@qayshp
Copy link
Contributor Author

qayshp commented Apr 25, 2018

from last run in Travis:
Total tests: 35. Passed: 34. Failed: 1. Skipped: 0.

Failed   GroupsCanBeRetrievedFromSearch
Error Message:
 Expected collection not to be empty.
Stack Trace:
   at FluentAssertions.Execution.XUnit2TestFramework.Throw(String message)
   at FluentAssertions.Execution.AssertionScope.FailWith(String message, Object[] args)
   at FluentAssertions.Collections.CollectionAssertions`2.NotBeEmpty(String because, Object[] becauseArgs)
   at GitLabApiClient.Test.GroupsClientTest.<GroupsCanBeRetrievedFromSearch>d__3.MoveNext() in /home/travis/build/nmklotas/GitLabApiClient/test/GitLabApiClient.Test/GroupsClientTest.cs:line 46
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
[xUnit.net 00:03:29.8189863]   Finished:    GitLabApiClient.Test

* Group `txxxestgrouxxxp` is created in `test_setup.sh`, so try using that group name instead of `gitlab`.
@qayshp qayshp closed this Apr 25, 2018
@qayshp qayshp reopened this Apr 25, 2018
@qayshp
Copy link
Contributor Author

qayshp commented Apr 25, 2018

I'm slightly confused and annoyed... the latest commit just pushed to my branch passed on Travis, while the build for this PR failed.
The only differences I can see are that the succeeding job was for commit qayshp@720a314 and the failing job was for commit 900732d which is just a non-fastforward merge.

@qayshp qayshp force-pushed the older-gitlab-docker branch 5 times, most recently from e932f42 to 42fb935 Compare April 25, 2018 05:43
@qayshp
Copy link
Contributor Author

qayshp commented Apr 25, 2018

Yes! Heisenbug identified! Naming the image from docker-compose would lead to the image being cached locally and reused for other builds based on the same image name + tag.

https://docs.docker.com/compose/compose-file/compose-file-v2/#build

@nmklotas
Copy link
Owner

Wow!! I've been struggling with builds failing with 401 on Travis! Thanks for solving this! :)

@nmklotas nmklotas merged commit 16a842b into nmklotas:master Apr 25, 2018
@qayshp qayshp deleted the older-gitlab-docker branch April 25, 2018 08:26
@qayshp
Copy link
Contributor Author

qayshp commented Apr 25, 2018

:\ celebrated too soon
Looks like there is still something funky going on, for example with https://travis-ci.org/nmklotas/GitLabApiClient/builds/370778025?utm_source=github_status&utm_medium=notification

@qayshp
Copy link
Contributor Author

qayshp commented Apr 25, 2018

Created and will continue discussion to #10 . I plan to keep working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants