Fix update period for dates older than a day #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For dates older than a day, and where `minPeriod` was set, the component updated every `minPeriod`. With this update, dates older than a day are always decided by the `maxPeriod` option.
|
Thanks! |
|
@nmn Thanks fo accepting. Could you release a new npm version? It needs this change to live up to its promise of "React-TimeAgo does the minimum amount of updates necessary." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For dates older than a day, and where
minPeriodwas set, the component updated everyminPeriod.With this update, dates older than a day are always decided by the
maxPeriodoption.