Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inform the user when device is not set correctly #90

Merged
merged 2 commits into from
Oct 2, 2023

Conversation

engintoklu
Copy link
Collaborator

In EvoTorch, the device of a problem must be set as "cpu" if the problem is configured to have multiple actors. With this pull request, when this rule is broken, a detailed error message is shown to the user. The error message also informs the user regarding what to do to fix the error.

In EvoTorch, the `device` of a problem must be
set as "cpu" if the problem is configured to have
multiple actors. With this commit, when this rule
is broken, a detailed error message is shown to
the user. The error message also informs the user
regarding what to do to fix the error.
@engintoklu engintoklu added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 30, 2023
@engintoklu engintoklu self-assigned this Sep 30, 2023
@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9d31d59) 77.83% compared to head (2b0ee41) 76.75%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #90      +/-   ##
==========================================
- Coverage   77.83%   76.75%   -1.09%     
==========================================
  Files          49       49              
  Lines        7332     7506     +174     
==========================================
+ Hits         5707     5761      +54     
- Misses       1625     1745     +120     
Files Coverage Δ
src/evotorch/core.py 74.30% <50.00%> (-0.20%) ⬇️

... and 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/evotorch/core.py Outdated Show resolved Hide resolved
@Higgcz Higgcz marked this pull request as ready for review October 2, 2023 15:33
@Higgcz Higgcz merged commit 6ce7c35 into master Oct 2, 2023
4 checks passed
@Higgcz Higgcz deleted the feature/detailed-device-err-msg branch October 2, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants