Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0.11 Not working in Firefox #28

Closed
rembo10 opened this issue Jul 14, 2015 · 10 comments
Closed

v1.0.11 Not working in Firefox #28

rembo10 opened this issue Jul 14, 2015 · 10 comments
Assignees

Comments

@rembo10
Copy link

rembo10 commented Jul 14, 2015

Hey - I was using the v1.0.10 release and it was working fine but the new version is broken in Firefox (works in chrome).

I get 'ReferenceError: event is not defined' when clicking on the card

Happens even when I try the demo flip at the top of http://nnattawat.github.io/flip/

@rembo10 rembo10 changed the title Not working in Firefox v1.0.11 Not working in Firefox Jul 14, 2015
@JemarJones
Copy link
Collaborator

Could you please show this in a JSfiddle if its easy enough to replicate?

Edit: Oops nvm i see that it exists on the demo.

@rembo10
Copy link
Author

rembo10 commented Jul 14, 2015

@rembo10
Copy link
Author

rembo10 commented Jul 14, 2015

Oh yeah - I basically just copied that example :-)

@rembo10
Copy link
Author

rembo10 commented Jul 14, 2015

I think I might have been using the v1.0.1 release also..... not v1.0.10.... i installed flip through bower and i think it pulled from this repo and not the Download repo, and i just tried to update a few hours ago (like, right after the project was merged back).... sorry for the confusion - I wasn't sure what was going on

@JemarJones
Copy link
Collaborator

Yea this issue seems to date back to at least 1.0.4, before i started contributing. I'll keep looking to try to figure this out though.

@JemarJones
Copy link
Collaborator

Appears to be specific to to the click trigger, not an issue with manual or hover.

Sorta just taking notes here ahah.

@rembo10
Copy link
Author

rembo10 commented Jul 14, 2015

Cool thanks!
On Jul 13, 2015 5:43 PM, "Jemar Jones" notifications@github.com wrote:

Yea this issue seems to date back to at least 1.0.4, before i started
contributing. I'll keep looking to try to figure this out though.


Reply to this email directly or view it on GitHub
#28 (comment).

@JemarJones
Copy link
Collaborator

Okay so i've now fixed this issue. Unfortunately i haven't been given push access to the main repo yet and do not know how to build a release myself. For now i've pushed my fix to the @Download fork here Download@a62b8f6, and we'll have to wait for him to build the release and pull the changes up here.

Thanks for spotting this!

Edit:
Scratch that, i'm now a Collaborator. Thanks @nnattawat!

@rembo10
Copy link
Author

rembo10 commented Jul 14, 2015

Not to worry. 1.0.1 works fine for me for the time being
On Jul 13, 2015 5:57 PM, "Jemar Jones" notifications@github.com wrote:

Okay so i've now fixed this issue. Unfortunately i haven't been given push
access to the main repo yet and do not know how to build a release myself.
For now i've pushed my fix to the @Download https://github.com/Download
fork here Download/flip@a62b8f6
Download@a62b8f6,
and we'll have to wait for to build the release and pull the changes up
here.

Thanks for spotting this!


Reply to this email directly or view it on GitHub
#28 (comment).

@JemarJones JemarJones self-assigned this Jul 14, 2015
@Download
Copy link
Collaborator

Fixed in v1.0.12. Please re-open if you still have issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants