Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

www: Hotfix for Crypto bug … #55

Merged
merged 1 commit into from
May 18, 2017
Merged

Conversation

joker234
Copy link
Member

@joker234 joker234 commented May 16, 2017

after commit 28e440a resp. #53

Please test this fix with care. In particular around the width of 1040px and with different browsers.

@joker234 joker234 requested review from koebi and cherti May 16, 2017 19:04
@cherti
Copy link
Member

cherti commented May 16, 2017

Could you provide an explanation of the behavior that was actually fixed? Because I didn't notice anything odd in my tests and testing is rather difficult when the original problem is unknown.^^

@joker234
Copy link
Member Author

screenshot_2017-05-16_21-15-45_ 0200
I got this ugly horizontal scroll bar if I use a browser with ~850 to ~1040px width. Chromium in my case. My hot fix was to set the max-width for loading the small.css to 1040px. There should be better possibilities in the future. One should open an issue on that.

@joker234 joker234 changed the title Hotfix for Crypto bug … www: Hotfix for Crypto bug … May 16, 2017
@cherti
Copy link
Member

cherti commented May 16, 2017

Ah, IC. I get that scrollbar without a threshold lower threshold, but always once the browser's width gets too small

@joker234
Copy link
Member Author

If it gets smaller then you should get an mobile design (small.css).

@cherti
Copy link
Member

cherti commented May 16, 2017

For very small widths, I get a reordering of the "next dates"-block below the text, but no change regarding the browse-bar at the top (both firefox and chromium).

@joker234
Copy link
Member Author

screenshot_2017-05-16_21-57-55_ 0200
at 850px width. Don't you see the difference?

Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.81 Safari/537.36

@cherti
Copy link
Member

cherti commented May 16, 2017

ah, yep, seen the small.css. Still get the vertical scrolling bar, though.

@joker234
Copy link
Member Author

you can ignore the vertical bar. This is a relict. If you click refresh it disappears.

@cherti
Copy link
Member

cherti commented May 17, 2017

äh, still get the horizontal scrollbar, I meant, with small.css

@cherti cherti merged commit 830b5b3 into master May 18, 2017
@cherti cherti deleted the crypto-header-layout-hotfix branch May 18, 2017 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants