Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webkit support #243

Merged
merged 8 commits into from
Oct 24, 2019
Merged

Webkit support #243

merged 8 commits into from
Oct 24, 2019

Conversation

MadeByDouglas
Copy link

Functionality is the same, but now uses WKWebView under the hood instead of UIWebView.

There are a few Todos which could clean up things, but its in good shape.

I changed default scroll bounce to true, seemed a better experience that way.

solves #240

Douglas Hewitt added 8 commits October 18, 2019 16:11
imported WebKit

use new delegate methods
replace javascript string methods

TODO: find return function for js string methods, verify keyboardDisplay and scalesPage can be removed or find alternative replacements
fixed issue where scripts were not properly being seen

also figured out how to get JSContext code to work with WKUserScript instead
not sure why you detail to having this off, experience is much better with it on.
@nnhubbard
Copy link
Owner

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants