Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eko.io.dictlike #351

Closed
felixhekhorn opened this issue Feb 29, 2024 · 2 comments
Closed

Update eko.io.dictlike #351

felixhekhorn opened this issue Feb 29, 2024 · 2 comments
Assignees
Labels
refactor Refactor code

Comments

@felixhekhorn
Copy link
Contributor

eko/src/eko/io/dictlike.py

Lines 150 to 157 in c8d2ea1

# FIXME: python 3.8 does not recognize the origin of `npt.NDArray`, but at
# the same time it is not a proper class since `numpy==1.23.2`, since it is
# not recognized by `inspect.isclass`, and `type(npt.NDArray)` is not
# inheriting from `type`
# However, this check should be matched by every version of NumPy for every
# version of Python supported
# Once py3.8 will be dropped, move this back below `inspect.isclass`
# assertion

Can you please take care of this @alecandido ?

@alecandido
Copy link
Member

Is this an urgent issue?

If it is not, I'd suggest dropping dictlike in favor of Pydantic, as suggested in #177.
I wrote dictlike myself, and it's a mess and plenty of tricks.

Instead, if someone is willing to take over, transitioning to Pydantic could be a good training, and I could provide guidance.

@felixhekhorn
Copy link
Contributor Author

Is this an urgent issue?

not at all - I was just searching for "3.8" in the code ...

If it is not, I'd suggest dropping dictlike in favor of Pydantic, as suggested in #177. I wrote dictlike myself, and it's a mess and plenty of tricks.

Instead, if someone is willing to take over, transitioning to Pydantic could be a good training, and I could provide guidance.

fine - I close this issue then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactor code
Projects
None yet
Development

No branches or pull requests

2 participants