Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] migrate TAOS CI --> gitaction CI #2463

Closed
6 tasks done
DonghakPark opened this issue Feb 6, 2024 · 1 comment
Closed
6 tasks done

[CI] migrate TAOS CI --> gitaction CI #2463

DonghakPark opened this issue Feb 6, 2024 · 1 comment

Comments

@DonghakPark
Copy link
Member

DonghakPark commented Feb 6, 2024 •
edited
Loading

  • cpp-linter
  • pylint
  • ubuntu build with meson (20.04, 22.04)
  • android build
  • prebuild ( commit message, sign, ... etc)
  • Upgrade Labeler (PR/READY2MERGE)
@taos-ci
Copy link
Collaborator

taos-ci commented Feb 6, 2024

:octocat: cibot: Thank you for posting issue #2463. The person in charge will reply soon.

DonghakPark added a commit to DonghakPark/nntrainer that referenced this issue Feb 6, 2024
@DonghakPark
[CI] Update cpp-linter ci (false file-annotations)
5509ebe 
For now we use cpp-linter as option 'file-annotations'
but there is too many annotations and that make hard to read code

So make false file-annotations & replace that to thread-comments

- fix typo for check cpp-linter exec

ref : https://github.com/marketplace/actions/c-c-linter

**Changes proposed in this PR:**
- modified:   .github/workflows/cpp_linter.yml
- modified:   nntrainer/dataset/func_data_producer.h

Resolves:
- nnstreamer#2463

**Self evaluation:**
1. Build test:	 [X]Passed [ ]Failed [ ]Skipped
2. Run test:	 [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghak PARK <donghak.park@samsung.com>
@DonghakPark DonghakPark mentioned this issue Feb 6, 2024
Merged
DonghakPark added a commit to DonghakPark/nntrainer that referenced this issue Feb 6, 2024
@DonghakPark
[CI] Update cpp-linter ci (false file-annotations)
e60424c 
For now we use cpp-linter as option 'file-annotations'
but there is too many annotations and that make hard to read code

So make false file-annotations & replace that to thread-comments

- fix typo for check cpp-linter exec

ref : https://github.com/marketplace/actions/c-c-linter

**Changes proposed in this PR:**
- modified:   .github/workflows/cpp_linter.yml
- modified:   nntrainer/dataset/func_data_producer.h

Resolves:
- nnstreamer#2463

**Self evaluation:**
1. Build test:	 [X]Passed [ ]Failed [ ]Skipped
2. Run test:	 [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghak PARK <donghak.park@samsung.com>
DonghakPark added a commit to DonghakPark/nntrainer that referenced this issue Feb 6, 2024
@DonghakPark
[CI] Update cpp-linter ci (false file-annotations)
0bc3ebe 
For now we use cpp-linter as option 'file-annotations'
but there is too many annotations and that make hard to read code

So make false file-annotations & replace that to thread-comments

- fix typo for check cpp-linter exec

ref : https://github.com/marketplace/actions/c-c-linter

**Changes proposed in this PR:**
- modified:   .github/workflows/cpp_linter.yml
- modified:   nntrainer/dataset/func_data_producer.h

Resolves:
- nnstreamer#2463

**Self evaluation:**
1. Build test:	 [X]Passed [ ]Failed [ ]Skipped
2. Run test:	 [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghak PARK <donghak.park@samsung.com>
DonghakPark added a commit to DonghakPark/nntrainer that referenced this issue Feb 6, 2024
@DonghakPark
[CI] Update cpp-linter ci (false file-annotations)
a27f7ac 
For now we use cpp-linter as option 'file-annotations'
but there is too many annotations and that make hard to read code

So make false file-annotations & replace that to thread-comments

- fix typo for check cpp-linter exec

ref : https://github.com/marketplace/actions/c-c-linter

**Changes proposed in this PR:**
- modified:   .github/workflows/cpp_linter.yml
- modified:   nntrainer/dataset/func_data_producer.h

Resolves:
- nnstreamer#2463

**Self evaluation:**
1. Build test:	 [X]Passed [ ]Failed [ ]Skipped
2. Run test:	 [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghak PARK <donghak.park@samsung.com>
DonghakPark added a commit to DonghakPark/nntrainer that referenced this issue Feb 6, 2024
@DonghakPark
[CI] Update cpp-linter ci (false file-annotations)
0d378ed 
For now we use cpp-linter as option 'file-annotations'
but there is too many annotations and that make hard to read code

So make false file-annotations & replace that to thread-comments

- fix typo for check cpp-linter exec

ref : https://github.com/marketplace/actions/c-c-linter

**Changes proposed in this PR:**
- modified:   .github/workflows/cpp_linter.yml
- modified:   nntrainer/dataset/func_data_producer.h

Resolves:
- nnstreamer#2463

**Self evaluation:**
1. Build test:	 [X]Passed [ ]Failed [ ]Skipped
2. Run test:	 [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghak PARK <donghak.park@samsung.com>
DonghakPark added a commit to DonghakPark/nntrainer that referenced this issue Feb 6, 2024
@DonghakPark
[CI] Update cpp-linter ci (false file-annotations)
def40ad 
For now we use cpp-linter as option 'file-annotations'
but there is too many annotations and that make hard to read code

So make false file-annotations & replace that to thread-comments

- fix typo for check cpp-linter exec

ref : https://github.com/marketplace/actions/c-c-linter

**Changes proposed in this PR:**
- modified:   .github/workflows/cpp_linter.yml
- modified:   nntrainer/dataset/func_data_producer.h

Resolves:
- nnstreamer#2463

**Self evaluation:**
1. Build test:	 [X]Passed [ ]Failed [ ]Skipped
2. Run test:	 [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghak PARK <donghak.park@samsung.com>
DonghakPark added a commit to DonghakPark/nntrainer that referenced this issue Feb 6, 2024
@DonghakPark
[CI] Update cpp-linter ci (false file-annotations)
0b644a3 
For now we use cpp-linter as option 'file-annotations'
but there is too many annotations and that make hard to read code

So make false file-annotations & replace that to step-summary

- fix typo for check cpp-linter exec

ref : https://github.com/marketplace/actions/c-c-linter

**Changes proposed in this PR:**
- modified:   .github/workflows/cpp_linter.yml
- modified:   nntrainer/dataset/func_data_producer.h

Resolves:
- nnstreamer#2463

**Self evaluation:**
1. Build test:	 [X]Passed [ ]Failed [ ]Skipped
2. Run test:	 [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghak PARK <donghak.park@samsung.com>
jijoongmoon pushed a commit that referenced this issue Feb 12, 2024
@DonghakPark @jijoongmoon
[CI] Update cpp-linter ci (false file-annotations)
4a9fbf2 
For now we use cpp-linter as option 'file-annotations'
but there is too many annotations and that make hard to read code

So make false file-annotations & replace that to step-summary

- fix typo for check cpp-linter exec

ref : https://github.com/marketplace/actions/c-c-linter

**Changes proposed in this PR:**
- modified:   .github/workflows/cpp_linter.yml
- modified:   nntrainer/dataset/func_data_producer.h

Resolves:
- #2463

**Self evaluation:**
1. Build test:	 [X]Passed [ ]Failed [ ]Skipped
2. Run test:	 [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghak PARK <donghak.park@samsung.com>
DonghakPark added a commit to DonghakPark/nntrainer that referenced this issue Feb 19, 2024
@DonghakPark
[CI] Update labeler : Add READY2MERGE label
f66d03d 
Currently, we have a git action that automatically labels as "Need Review" when the number of reviews is insufficient, and removes it when necessary. This automation allows developers to know which pull requests need review.

In addition, we want to automate the process of labeling pull requests that require merging, to make it more convenient for developers.

Resolves:
    nnstreamer#2463

**Self evaluation:**
1. Build test:	 [X]Passed [ ]Failed [ ]Skipped
2. Run test:	 [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghak PARK <donghak.park@samsung.com>
@DonghakPark DonghakPark mentioned this issue Feb 19, 2024
Merged
EunjuYang pushed a commit to EunjuYang/nntrainer that referenced this issue Aug 28, 2024
@DonghakPark @EunjuYang
[CI] Update cpp-linter ci (false file-annotations)
d9f6239 
For now we use cpp-linter as option 'file-annotations'
but there is too many annotations and that make hard to read code

So make false file-annotations & replace that to step-summary

- fix typo for check cpp-linter exec

ref : https://github.com/marketplace/actions/c-c-linter

**Changes proposed in this PR:**
- modified:   .github/workflows/cpp_linter.yml
- modified:   nntrainer/dataset/func_data_producer.h

Resolves:
- nnstreamer#2463

**Self evaluation:**
1. Build test:	 [X]Passed [ ]Failed [ ]Skipped
2. Run test:	 [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghak PARK <donghak.park@samsung.com>
EunjuYang pushed a commit to EunjuYang/nntrainer that referenced this issue Aug 28, 2024
@DonghakPark @EunjuYang
[CI] Update labeler : Add READY2MERGE label
14e5fb4 
Currently, we have a git action that automatically labels as "Need Review" when the number of reviews is insufficient, and removes it when necessary. This automation allows developers to know which pull requests need review.

In addition, we want to automate the process of labeling pull requests that require merging, to make it more convenient for developers.

Resolves:
    nnstreamer#2463

**Self evaluation:**
1. Build test:	 [X]Passed [ ]Failed [ ]Skipped
2. Run test:	 [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghak PARK <donghak.park@samsung.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@taos-ci @DonghakPark