-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Trivial] Delete duplicated file @open sesame 11/19 10:09 #1712
Conversation
📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #1712. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnstreamer.mooo.com/. |
We generate a report if there are dangerous coding constructs in your code. Please read http://nnstreamer.mooo.com/nntrainer/ci/repo-workers/pr-checker/1712-202111171203100.26684403419495-e1220d7c068289a57e823aee8c8739515faa5748/report/. |
INFO: You can read if there are misspelled characters at our misspelling check report. Please read http://nnstreamer.mooo.com/nntrainer/ci/repo-workers/pr-checker/1712-202111171203100.26684403419495-e1220d7c068289a57e823aee8c8739515faa5748/report/. |
/** | ||
* Copyright (C) 2020 Parichay Kapoor <pk.kapoor@samsung.com> | ||
* | ||
* @file unittest_nntrainer_layers.cpp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is unittest_layer_node.cpp although it's also not used anywhere.
cibot: @zhoonit, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://nnstreamer.mooo.com/nntrainer/ci/repo-workers/pr-checker/1712-202111171203100.26684403419495-e1220d7c068289a57e823aee8c8739515faa5748/. |
Need discussion later. |
e1220d7
to
bca4151
Compare
We generate a report if there are dangerous coding constructs in your code. Please read http://nnstreamer.mooo.com/nntrainer/ci/repo-workers/pr-checker/1712-202111180745350.14792704582214-bca41514c73d35c581ef56ff1b61a5abd5b90d05/report/. |
INFO: You can read if there are misspelled characters at our misspelling check report. Please read http://nnstreamer.mooo.com/nntrainer/ci/repo-workers/pr-checker/1712-202111180745350.14792704582214-bca41514c73d35c581ef56ff1b61a5abd5b90d05/report/. |
cibot: @zhoonit, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://nnstreamer.mooo.com/nntrainer/ci/repo-workers/pr-checker/1712-202111180745350.14792704582214-bca41514c73d35c581ef56ff1b61a5abd5b90d05/. |
I have moved the comment to nnstreamer/api#110 for better discussion, the issue addressed is not related to the PR :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We generate a report if there are dangerous coding constructs in your code. Please read http://nnstreamer.mooo.com/nntrainer/ci/repo-workers/pr-checker/1712-202111191011040.14259505271912-bca41514c73d35c581ef56ff1b61a5abd5b90d05/report/. |
INFO: You can read if there are misspelled characters at our misspelling check report. Please read http://nnstreamer.mooo.com/nntrainer/ci/repo-workers/pr-checker/1712-202111191011040.14259505271912-bca41514c73d35c581ef56ff1b61a5abd5b90d05/report/. |
This patch delete duplicated test file that is not used anywhere **Self evaluation:** 1. Build test: [X]Passed [ ]Failed [ ]Skipped 2. Run test: [X]Passed [ ]Failed [ ]Skipped Signed-off-by: Jihoon Lee <jhoon.it.lee@samsung.com>
bca4151
to
056f6cd
Compare
We generate a report if there are dangerous coding constructs in your code. Please read http://nnstreamer.mooo.com/nntrainer/ci/repo-workers/pr-checker/1712-202111191033300.18561291694641-056f6cd18a0b61c34dfd1a36b61ac77aca0e2379/report/. |
INFO: You can read if there are misspelled characters at our misspelling check report. Please read http://nnstreamer.mooo.com/nntrainer/ci/repo-workers/pr-checker/1712-202111191033300.18561291694641-056f6cd18a0b61c34dfd1a36b61ac77aca0e2379/report/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhoonit, 💯 All CI checkers are successfully verified. Thanks.
Dependency of the PR
Commits to be reviewed in this PR
[Trivial] Delete duplicated file
This patch delete duplicated test file that is not used anywhere
Self evaluation:
Signed-off-by: Jihoon Lee jhoon.it.lee@samsung.com