blas_neon: fix compiler errors in aarch64/Linux #2430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myungjoo
requested review from
jijoongmoon,
again4you,
jaeyun-jung,
leemgs,
wooksong,
helloahn,
kparichay,
gichan-jang,
anyj0527,
zhoonit and
a team
as code owners
|
📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2430. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/. |
myungjoo
force-pushed
the
fix/blas_neon.cpp/builderr
branch
2 times, most recently
from
729b214
to
d8bb271
Compare
With stricter compilers, fp16 codes are not compilable. To enable testing in non-android, fix type mismatches. Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
myungjoo
force-pushed
the
fix/blas_neon.cpp/builderr
branch
from
d8bb271
to
859a336
Compare
myungjoo
requested review from
lhs8928,
songgot,
jihochu,
DonghakPark,
SeoHyungjun,
baek2sm,
skykongkong8 and
EunjuYang
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With stricter compilers, fp16 codes are not compilable.
To enable testing in non-android, fix type mismatches.
@s-debadri Note that there have been critical errors that Android compilers have ignored:
a < b >= cis not interpreted by C/C++ compilers as intended.It is going to be interpreted as:
( a < b ) ? ( 1 >= c ) : ( 0 >= c ), not(a < b) && (b >= c)The compiler must have complained about this error/warning. Please DO NOT ignore or suppress them. Correct the code if there are warnings, please.
And
float Y32[rows];(rows is a variable) is not in C/C++ syntax.