Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement correct_vuv_by_phone using C-VUV_Voiced and C-VUV_Unvoiced flags #119

Merged
merged 2 commits into from
Jun 18, 2022

Conversation

r9y9
Copy link
Collaborator

@r9y9 r9y9 commented Jun 18, 2022

The new implementation will look C-VUV_Voiced and C-VUV_Unvoiced flags to correct V/UV.

Changes:

  • Stop looking "C-Phone_Yuusei_Boin" flag to be language-independent
  • Correct both voice/unvoiced sounds by "C-VUV_Voiced" and "C-VUV_Unvoiced" flags
  • add tests

ref #95

- Stop looking "C-Phone_Yuusei_Boin" flag to be language independent
- Correct both voice/unvoiced sounds by "C_VUV_Voied" and
  "C_VUV_Unvoiceed" flags
- add tests
@r9y9 r9y9 added the new feature new feature label Jun 18, 2022
@r9y9 r9y9 self-assigned this Jun 18, 2022
@r9y9 r9y9 changed the title Implement correct_vuv_by_phone and make it language-independent Implement correct_vuv_by_phone using C-VUV_Voiced and C-VUV_Unvoiced flags Jun 18, 2022
@r9y9 r9y9 merged commit 5df4bc8 into master Jun 18, 2022
@r9y9 r9y9 deleted the fix-force-vuv branch June 18, 2022 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant