-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements basic Firebase functionality #8
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds editing functionality to main screen: - transcripts can be read aloud & stored as prerecordings. - prerecordings can be deleted and modified. The `configuration-prerecording-sidebar.component` is not really needed anymore after this change, but we still keep it for the time being.
Instead of the super hacky storage of the password in localStorage.
Without this default value, f6cb23 broke previous microphone settings leading to a rendering error of input messages (in `transcript.component.html` when setting the `[ngClass]` on line 16).
Before this fix e.g. arrow right could not be used to move the caret inside a text input (e.g. override text input).
The override pane now has no description other than the placeholder, and a single text input is used for both bot and user. The new developer toggle can be used to enable a bunch of useful, but potentially dangerous actions.
Implemented: - multiple users with their own collections/documents. - load API keys from db when logged in - store conversations to db Not implemented yet: - store prerecordings and system prompts
* noodles/main: Sets default microphone role to user. feat: add light controller
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
The previous pattern – using getFirstValue – did not work as expected, in particular it did not fetch the latest value of the settings when loading them from Firebase on startup.
no0dles
reviewed
May 8, 2023
src/app/components/configuration-openai-sidebar/configuration-openai-sidebar.component.html
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two things
A bunch of small UI improvements, namely the possibility to "override" bot/user via Keyboard, and a new "Developer" toggle that enables some practical but not-too-safe features like single-click deleting pre-recordings, and reading messages aloud via the currently selected voice.
Firebase functionality: Once a user is logged in, the Firestore database is used to load API keys, and cost and conversations are sent to the server for later analysis. Note that the entire app still works perfectly fine without being logged in (in that case the user has to provide API keys themselves though, as was the case already before this PR).