Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix examples #135

Merged
merged 4 commits into from
Jun 7, 2024
Merged

Fix examples #135

merged 4 commits into from
Jun 7, 2024

Conversation

zmoon
Copy link
Member

@zmoon zmoon commented Jun 6, 2024

closes #110

@zmoon
Copy link
Member Author

zmoon commented Jun 6, 2024

Yay now it correctly fails. Still gotta actually fix the examples though...

zmoon added 3 commits June 7, 2024 10:26
in multiple txt outputs so don't add group attr, otherwise conflict
@zmoon zmoon marked this pull request as ready for review June 7, 2024 16:52
@zmoon
Copy link
Member Author

zmoon commented Jun 7, 2024

@drnimbusrain any new features to highlight in the 1-D examples?

@drnimbusrain
Copy link
Member

@drnimbusrain any new features to highlight in the 1-D examples?

@zmoon Thank you for working on these updates! Most recently we have been working on the biogenic emissions, and have added a number of new options that I think could be added and useful for 1-D examples. See the new biogenic options, loss_opt, leafage_opt,hist_opt, and soim_opt.

@zmoon
Copy link
Member Author

zmoon commented Jun 7, 2024

@drnimbusrain I think we can address that in a separate PR, keep this one simple.

@zmoon zmoon requested a review from drnimbusrain June 7, 2024 18:18
@drnimbusrain drnimbusrain merged commit ea49955 into develop Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Notebook failure doesn't fail CI?
2 participants