-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump adcircpy version to v1.1.0
#69
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-assigned this
Jan 20, 2022
ghost
deleted the
feature/adcircpy_bump
branch
February 17, 2022 14:19
ghost
pushed a commit
that referenced
this pull request
Mar 7, 2022
ghost
pushed a commit
that referenced
this pull request
Apr 27, 2022
…ing (#80) * adding sciki linear regression_model kwarg into surrogate from training, and use of LassoCV model in the example * add options for analysis in log scale and conversion from depths to elevations in the output * adding minimum allowable value (for adcirc this is depth of 0.8*h0) option for surrogate model * adding boxplot showing error distribution of surrogate model across the runs, change normalized bias/mean error to dimensional one * subsetting by wind swath in example * adding ability to handle sometimes wet sometimes dry nodes into the example correctly * adding option to use sklearn PCA tool for the Karhunen-loeve decomposition as this seems to be faster and can handle larger datasets. Switched matrix order for the KL mode to avoid transposes and be consistent with the sklearn output. * adding correlation coefficient for wet/dry logical switch, increasing height of surrogte KL fit plot where required * adding subset_dataset option to adcirc parser that renumbers and transfers over element table if present * correcting subsetting with elements inside, adding surface plotter to geometry * adding KL surface plot option and adding element table into sensitivities dataset * adding element_table into surrogate output netcdf/xarray.Datasets, and updating plotting for KL prediction * adding surface plot option for sensitivities and changing colorbar to plasma * redefining placement of colorbar for sensitivities plot * adding plot surface ability for validation and percentiles * change colormap extent to only consider model source * Adding an elevation extrapolator over dry nodes to avoid setting these to a small constant null depth value which was negatively affecting the surrogate generation. Adjusting some validation plotting axis and colormap limits * send kwargs to coastline plot function * build on latest Python * bump adcircpy version (#69) * change `storm_id` to `nhc_code` * change `sample_rule` to `sample-rule` * change `sample_rule` to `sample-rule` * internal refactoring * remove unused dependencies * tables is not named the same on Anaconda * formatting * update setup and package installation (#75) * use `gartersnake` * update build system * update build system * update build system * update build system * update build system * update Python testing version * update workflows * making water elevation dataarray output a deep copy * change handling of training/validation datasets for the conversion from log scale and depths when generating the surrogate so that the original datasets are kept for validation purposes and only the surrogate is converted back from log scale and from depths * instead of modifiying minimum_allowable_value for surrogate model evaluation first subtract off convert_from_depths which can be either numpy.ndarray or float * implementing headloss methodology for extrapolating water elevations over the floodplain * correcting p for idw_order in elevation extrapolation idw routine * adding capabilities for sparse quadrature and other user-defined options for generating the quadrature * correcting vortex attribute to and removing old unnecessary code * adding sciki linear regression_model kwarg into surrogate from training, and use of LassoCV model in the example * add options for analysis in log scale and conversion from depths to elevations in the output * adding minimum allowable value (for adcirc this is depth of 0.8*h0) option for surrogate model * adding boxplot showing error distribution of surrogate model across the runs, change normalized bias/mean error to dimensional one * subsetting by wind swath in example * adding ability to handle sometimes wet sometimes dry nodes into the example correctly * adding option to use sklearn PCA tool for the Karhunen-loeve decomposition as this seems to be faster and can handle larger datasets. Switched matrix order for the KL mode to avoid transposes and be consistent with the sklearn output. * adding correlation coefficient for wet/dry logical switch, increasing height of surrogte KL fit plot where required * adding subset_dataset option to adcirc parser that renumbers and transfers over element table if present * correcting subsetting with elements inside, adding surface plotter to geometry * adding KL surface plot option and adding element table into sensitivities dataset * adding element_table into surrogate output netcdf/xarray.Datasets, and updating plotting for KL prediction * adding surface plot option for sensitivities and changing colorbar to plasma * redefining placement of colorbar for sensitivities plot * adding plot surface ability for validation and percentiles * change colormap extent to only consider model source * Adding an elevation extrapolator over dry nodes to avoid setting these to a small constant null depth value which was negatively affecting the surrogate generation. Adjusting some validation plotting axis and colormap limits * making water elevation dataarray output a deep copy * change handling of training/validation datasets for the conversion from log scale and depths when generating the surrogate so that the original datasets are kept for validation purposes and only the surrogate is converted back from log scale and from depths * instead of modifiying minimum_allowable_value for surrogate model evaluation first subtract off convert_from_depths which can be either numpy.ndarray or float * implementing headloss methodology for extrapolating water elevations over the floodplain * correcting p for idw_order in elevation extrapolation idw routine * adding capabilities for sparse quadrature and other user-defined options for generating the quadrature * correcting vortex attribute to and removing old unnecessary code * updating KLPC example to fit new changes * deleting RunTimeError for try except on Version retrieval in setup.py which is not working * updating cyclone subsetting to new VortexTrack implementation and geopandas sjoin commands, and adding dask call * send warning for general exception when retrieving VCS-tagged version * apply `isort` and linter * use future-compatible import for vortextrack * pin this version below `stormevents` `1.2.3` * bumping stormevents to 1.2.5 version for working version with old API * introducing inhouse sampling method that equally divides the distribution within the given fraction of the distribution * changing Vmax bounds * adding maximum_depth subsetting ability, and correctly treating None node_status_mask * plotting changes: changing perturbation matrix to plot different sizes and gray colors for quadrature weights, adding extend and label options to colorbar_axis, adding color_map and kwarg options to node_map plot * adding option to specify log base, and correcting convert_from_depths for numpy array input * update reference files * formatting Co-authored-by: zacharyburnettNOAA <zachary.burnett@noaa.gov>
SorooshMani-NOAA
pushed a commit
that referenced
this pull request
Jun 21, 2022
* adding sciki linear regression_model kwarg into surrogate from training, and use of LassoCV model in the example * add options for analysis in log scale and conversion from depths to elevations in the output * adding minimum allowable value (for adcirc this is depth of 0.8*h0) option for surrogate model * adding boxplot showing error distribution of surrogate model across the runs, change normalized bias/mean error to dimensional one * subsetting by wind swath in example * adding ability to handle sometimes wet sometimes dry nodes into the example correctly * adding option to use sklearn PCA tool for the Karhunen-loeve decomposition as this seems to be faster and can handle larger datasets. Switched matrix order for the KL mode to avoid transposes and be consistent with the sklearn output. * adding correlation coefficient for wet/dry logical switch, increasing height of surrogte KL fit plot where required * adding subset_dataset option to adcirc parser that renumbers and transfers over element table if present * correcting subsetting with elements inside, adding surface plotter to geometry * adding KL surface plot option and adding element table into sensitivities dataset * adding element_table into surrogate output netcdf/xarray.Datasets, and updating plotting for KL prediction * adding surface plot option for sensitivities and changing colorbar to plasma * redefining placement of colorbar for sensitivities plot * adding plot surface ability for validation and percentiles * change colormap extent to only consider model source * Adding an elevation extrapolator over dry nodes to avoid setting these to a small constant null depth value which was negatively affecting the surrogate generation. Adjusting some validation plotting axis and colormap limits * send kwargs to coastline plot function * build on latest Python * bump adcircpy version (#69) * change `storm_id` to `nhc_code` * change `sample_rule` to `sample-rule` * change `sample_rule` to `sample-rule` * internal refactoring * remove unused dependencies * tables is not named the same on Anaconda * formatting * update setup and package installation (#75) * use `gartersnake` * update build system * update build system * update build system * update build system * update build system * update Python testing version * update workflows * making water elevation dataarray output a deep copy * change handling of training/validation datasets for the conversion from log scale and depths when generating the surrogate so that the original datasets are kept for validation purposes and only the surrogate is converted back from log scale and from depths * instead of modifiying minimum_allowable_value for surrogate model evaluation first subtract off convert_from_depths which can be either numpy.ndarray or float * implementing headloss methodology for extrapolating water elevations over the floodplain * correcting p for idw_order in elevation extrapolation idw routine * adding capabilities for sparse quadrature and other user-defined options for generating the quadrature * correcting vortex attribute to and removing old unnecessary code * adding sciki linear regression_model kwarg into surrogate from training, and use of LassoCV model in the example * add options for analysis in log scale and conversion from depths to elevations in the output * adding minimum allowable value (for adcirc this is depth of 0.8*h0) option for surrogate model * adding boxplot showing error distribution of surrogate model across the runs, change normalized bias/mean error to dimensional one * subsetting by wind swath in example * adding ability to handle sometimes wet sometimes dry nodes into the example correctly * adding option to use sklearn PCA tool for the Karhunen-loeve decomposition as this seems to be faster and can handle larger datasets. Switched matrix order for the KL mode to avoid transposes and be consistent with the sklearn output. * adding correlation coefficient for wet/dry logical switch, increasing height of surrogte KL fit plot where required * adding subset_dataset option to adcirc parser that renumbers and transfers over element table if present * correcting subsetting with elements inside, adding surface plotter to geometry * adding KL surface plot option and adding element table into sensitivities dataset * adding element_table into surrogate output netcdf/xarray.Datasets, and updating plotting for KL prediction * adding surface plot option for sensitivities and changing colorbar to plasma * redefining placement of colorbar for sensitivities plot * adding plot surface ability for validation and percentiles * change colormap extent to only consider model source * Adding an elevation extrapolator over dry nodes to avoid setting these to a small constant null depth value which was negatively affecting the surrogate generation. Adjusting some validation plotting axis and colormap limits * making water elevation dataarray output a deep copy * change handling of training/validation datasets for the conversion from log scale and depths when generating the surrogate so that the original datasets are kept for validation purposes and only the surrogate is converted back from log scale and from depths * instead of modifiying minimum_allowable_value for surrogate model evaluation first subtract off convert_from_depths which can be either numpy.ndarray or float * implementing headloss methodology for extrapolating water elevations over the floodplain * correcting p for idw_order in elevation extrapolation idw routine * adding capabilities for sparse quadrature and other user-defined options for generating the quadrature * correcting vortex attribute to and removing old unnecessary code * updating KLPC example to fit new changes * deleting RunTimeError for try except on Version retrieval in setup.py which is not working * updating cyclone subsetting to new VortexTrack implementation and geopandas sjoin commands, and adding dask call * send warning for general exception when retrieving VCS-tagged version * apply `isort` and linter * use future-compatible import for vortextrack * pin this version below `stormevents` `1.2.3` * bumping stormevents to 1.2.5 version for working version with old API * introducing inhouse sampling method that equally divides the distribution within the given fraction of the distribution * changing Vmax bounds * adding maximum_depth subsetting ability, and correctly treating None node_status_mask * plotting changes: changing perturbation matrix to plot different sizes and gray colors for quadrature weights, adding extend and label options to colorbar_axis, adding color_map and kwarg options to node_map plot * adding option to specify log base, and correcting convert_from_depths for numpy array input * update reference files * formatting * adding both extrapolation and no extrapolation klpc examples * commenting out scatter validation plot due to takes a lot of memory and time to plot for large mesh and ensemble -- can move to density scatter plot in future * Auto fixing linting errors Co-authored-by: zacharyburnettNOAA <zachary.burnett@noaa.gov>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.