Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make_unique<>() not supported on gcc 4.8.5 #81

Closed
hellkite500 opened this issue May 20, 2020 · 2 comments
Closed

make_unique<>() not supported on gcc 4.8.5 #81

hellkite500 opened this issue May 20, 2020 · 2 comments

Comments

@hellkite500
Copy link
Member

hellkite500 commented May 20, 2020 •
edited
Loading

RHEL/CentOS 7 gcc tool chain is 4.8.5 and even with --std=c++1y (for c++14) make_unique is not supported.

Current behavior

Build fails using gcc 4.8.5 with c++14 standards

Expected behavior

Buildable on RHEL/ContOS 7

##Proposed
add a custom make_unique<>() implementation in utilities with a macro gaurd to enable it for gcc < 4.9
@ZacharyWills
Copy link
Contributor

ZacharyWills commented May 20, 2020 •
edited
Loading

Is there a known working compiler version? We can test both compilers to see when they align after that's added.

@donaldwj donaldwj mentioned this issue Jun 29, 2020
Merged
11 tasks
@hellkite500
Copy link
Member Author

Closed by #106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hellkite500 @ZacharyWills