-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: PC-12940/PC-12941 Allow to configure budget drop condition type #423
Merged
nobl9-adam-szymanski
merged 8 commits into
main
from
PC-12940/PC-12941-allow-to-configure-budget-drop-condition-type
Jun 25, 2024
Merged
feat: PC-12940/PC-12941 Allow to configure budget drop condition type #423
nobl9-adam-szymanski
merged 8 commits into
main
from
PC-12940/PC-12941-allow-to-configure-budget-drop-condition-type
Jun 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nobl9-adam-szymanski
requested review from
nieomylnieja,
skrolikiewicz and
daniel-zelazny
as code owners
May 28, 2024 17:16
…ow-to-configure-budget-drop-condition-type
piotrkwarcinski
requested changes
Jun 13, 2024
Co-authored-by: Piotr Kwarciński <100768054+piotrkwarcinski@users.noreply.github.com>
…drop-condition-type
piotrkwarcinski
approved these changes
Jun 17, 2024
piotrkwarcinski
approved these changes
Jun 17, 2024
…drop-condition-type
…drop-condition-type
nobl9-adam-szymanski
deleted the
PC-12940/PC-12941-allow-to-configure-budget-drop-condition-type
branch
June 25, 2024 10:19
piotrkwarcinski
restored the
PC-12940/PC-12941-allow-to-configure-budget-drop-condition-type
branch
June 25, 2024 10:58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Allow to configure new condition type based on budget drop.
Summary
budgetDrop
.lastsFor
for new condition type.alertingWindow
for new condition type.Testing
Run
sloctl apply -f fast-budget.yaml
:Release Notes
Add support for new alerting condition based on budget drop with new measurement
budgetDrop
.Example: